Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#16129 closed defect (fixed)

IE10 Textarea shrinking

Reported by: haysmark Owned by: Douglas Hays
Priority: undecided Milestone: 1.6.2
Component: Dijit - Form Version: 1.8.0
Keywords: dohfail Cc:
Blocked By: Blocking:

Description

     Error: doh._AssertFailure: assertTrue('false') failed with hint: 
 		height should not shrink

     ERROR IN:
 		 function(){
							var
								d = new doh.Deferred(),
								w = dijit.byId("programmatic");

							focusThenRun(w, function(){
								var h = parseInt(w.domNode.style.height);
								doh.robot.keyPress(" ", 500, {});
								doh.robot.sequence(d.getTestCallback(function(){
									doh.t(parseInt(w.domNode.style.height) >= h, "height should not shrink");
								}), 500);
							});

							return d;
						}
 FAILED test: ../../dijit/tests/form/robot/Textarea.html::miscellaneous::#13166 1052 ms

Attachments (2)

16129.patch (16.2 KB) - added by Douglas Hays 7 years ago.
fix
16129_1_7.patch (3.8 KB) - added by bill 6 years ago.
attempted patch against 1.7, but turns out that 1.7 is apparently working against IE10 already

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by haysmark

Keywords: dohfail added

comment:2 Changed 7 years ago by haysmark

The issue in IE10 is that the programmatic text area shrinks when you click inside of it.

  • IE9 exhibits the same shrinking behavior.
  • IE9 in IE8 mode passes.
  • In IE9 in IE7 mode, the Textarea actually expands! The error is "expected 64 but got 80 with hint: height should not change"
  • Chrome 22 exhibits the same shrinking behavior as IE10.

comment:3 Changed 7 years ago by Douglas Hays

Milestone: tbd1.8.2
Status: newassigned

Changed 7 years ago by Douglas Hays

Attachment: 16129.patch added

fix

comment:4 Changed 7 years ago by haysmark

I was seeing a failure in "delete until less than max-height" but I updated SVN this morning and am not seeing it. Also I applied the patch to 1.8 and the test passed there in IE10 as well. I will test 1.8 further.

Last edited 7 years ago by haysmark (previous) (diff)

comment:5 Changed 7 years ago by haysmark

I further tested the change in 1.8 in the following browsers and had no issues:

  • IE9
  • Firefox 15
  • Chrome 22

I am trying to test in Safari 5.1.7 but its Java detection is being stupid.

comment:6 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [29858]:

Fixes #16129, #16142. Watch resize events on TEXTAREA elements for changes. Fixup scrollTop in case max-height is being set by user. Add automated tests.

Changed 6 years ago by bill

Attachment: 16129_1_7.patch added

attempted patch against 1.7, but turns out that 1.7 is apparently working against IE10 already

comment:7 Changed 6 years ago by Douglas Hays

In [30387]:

Refs #16129. Backport IE10 support for Textarea back thru 1.6.

comment:8 Changed 6 years ago by Douglas Hays

Milestone: 1.8.21.6.2
Note: See TracTickets for help on using tickets.