Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#16126 closed defect (fixed)

IE10 Toolbar test failure

Reported by: haysmark Owned by: bill
Priority: undecided Milestone: 1.5.3
Component: Dijit Version: 1.7.4rc1
Keywords: dohfail Cc:
Blocked By: Blocking:

Description

     Error: doh._AssertFailure: assertEqual() failed:
 	expected
		user
	but got
		tooltipDlg


     ERROR IN:
 		 function(){
							var d = new doh.Deferred();

							// Re-enable the ToolipDialog and ColorPalette drop down so that we can test it
							registry.byId("toolbar1.dialog").set("disabled", false);
							registry.byId("toolbar1.backcolor").set("disabled", false);

							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								toolbar1Before.focus();
							})), 500);

							// Tab into toolbar and move to tooltip dialog button
							robot.keyPress(keys.TAB, 500, {});
							robot.keyPress(keys.RIGHT_ARROW, 500, {});

							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								doh.is("toolbar1.dialog", dfocus.curNode.id, "dialog button, first visit");
							})), 1000);

							// Open the dialog, focus should go to first input
							robot.keyPress(keys.DOWN_ARROW, 500, {});
							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								doh.is("user", dfocus.curNode.id);
							})), 1000);

							// ESC should restore focus to toolbar dialog button
							robot.keyPress(keys.ESCAPE, 500, {});
							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								doh.is("toolbar1.dialog", dfocus.curNode.id, "dialog button, second visit");
							})), 1000);

							// Open the dialog again
							robot.keyPress(keys.DOWN_ARROW, 500, {});
							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								doh.is("user", dfocus.curNode.id, "user, again");
							})), 1000);

							// Submit should also restore focus to toolbar dialog button, assuming that it
							// doesn't reset the focus somewhere else (like into the editor)
							robot.keyPress(keys.TAB, 500);
							robot.keyPress(keys.TAB, 500);
							robot.keyPress(keys.ENTER, 500);
							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								doh.is("toolbar1.dialog", dfocus.curNode.id, "dialog button, third visit");
							})), 1000);

							// Try the ColorPalette
							robot.keyPress(keys.RIGHT_ARROW, 500);
							robot.keyPress(keys.DOWN_ARROW, 500);
							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								doh.t(dom.isDescendant(dfocus.curNode, registry.byId("toolbar1.colorPalette").domNode),
									"focus inside colorpalette, actual focus is: " + (dfocus.curNode ?
										(dfocus.curNode.id||"no id") : "no focus"));
							})), 1000);
							robot.keyPress(keys.RIGHT_ARROW, 500);	// navigation in the ColorPalette
							robot.keyPress(keys.DOWN_ARROW, 500);	// navigation in the ColorPalette
							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								doh.t(dom.isDescendant(dfocus.curNode, registry.byId("toolbar1.colorPalette").domNode),
									"focus still inside colorpalette, actual focus is: " + (dfocus.curNode ?
										(dfocus.curNode.id||"no id") : "no focus"));
							})), 1000);
							
							// pressing tab in the colorpalette should move focus back to the toolbar
							robot.keyPress(keys.TAB, 500);
							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								doh.is("toolbar1.backcolor", dfocus.curNode.id, "back on colorpalette button");
							})), 1000);

							// try the ComboButton
							robot.keyPress(keys.RIGHT_ARROW, 500);
							robot.keyPress(keys.RIGHT_ARROW, 500);
							robot.keyPress(keys.DOWN_ARROW, 500);
							robot.sequence(d.getTestErrback(lang.hitch(this, function(){
								// TODO: test that focus is on menu
							})), 1000);
							robot.keyPress(keys.SPACE, 500);	// select first menu option
							robot.sequence(d.getTestCallback(lang.hitch(this, function(){
								// TODO: test that focus is returned to button
							})), 1000);

							return d;
						}
 FAILED test: ../../dijit/tests/robot/Toolbar.html::keyboard::drop downs 4053 ms

Change History (10)

comment:1 Changed 7 years ago by haysmark

Keywords: dohfail added

comment:2 Changed 7 years ago by bill

Can be seen in test_Toolbar.html. If you use the keyboard to get focus on the TooltipDialog button, and then press the down arrow, the TooltipDialog opens but the first field doesn't get focus. (Nothing seems to get focus.)

comment:3 Changed 7 years ago by bill

Milestone: tbd1.8.2

Bulk update of IE10 tickets to 1.8.2, as per meeting. Backports to 1.4 will be handled in a separate ticket. If this ticket just requires a test update, it can be rescheduled for milestone 1.9, and checked into trunk only.

comment:4 Changed 6 years ago by haysmark

Version: 1.8.01.7.4rc1

comment:5 Changed 6 years ago by bill

Resolution: fixed
Status: newclosed

In [30083]:

Fix code to find tab navigable elements on IE10.

Refs #10719, fixes #16126 on trunk !strict

comment:8 Changed 6 years ago by bill

In [30084]:

Fix code to find tab navigable elements on IE10.

Refs #10719, fixes #16126 on 1.8 branch !strict

comment:9 Changed 6 years ago by bill

In [30085]:

Backport [30083] to 1.7 branch, restricting VML check to IE <= 9, refs #10719 and fixes #16123, #16124, #16126 on 1.7 branch !strict

comment:10 Changed 6 years ago by bill

In [30086]:

Backport [30083] to 1.6 branch, restricting VML check to IE <= 9, refs #10719 and fixes #16123, #16124, #16126 on 1.6 branch !strict

comment:11 Changed 6 years ago by bill

In [30087]:

Backport [30083] to 1.5 branch, restricting VML check to IE <= 9, refs #10719 and fixes #16123, #16124, #16126 on 1.5 branch !strict

comment:12 Changed 6 years ago by bill

Milestone: 1.8.21.5.3

Fixed back to 1.5 theoretically, at least fixed the cause of the failure in 1.8.

Note: See TracTickets for help on using tickets.