Opened 9 years ago
Closed 5 years ago
#16111 closed defect (fixed)
dojo/fx.js needs a type check to avoid error in less than IE8.
Reported by: | chrisacky | Owned by: | dylan |
---|---|---|---|
Priority: | low | Milestone: | 1.7.9 |
Component: | fx | Version: | 1.8.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
This issue seems too only effect versions of Internet Explorer 7/8.
When chaining animations together, even when you set an duration, and *even* though there is a default duration on all animations, IE7/8 seems to fail when performing some animations.
Error Message:
SCRIPT5007: Unable to get value of the property 'duration': object is null or undefined fx.js, line 47 character 4
The simple fix is to add a typeof check in dojo/fx.js to make sure that duration exists.
For instance replace (on line 47):
this.duration += a.duration; if(a.delay){ this.duration += a.delay; }
With this:
if(a && typeof a.duration != "undefined"){ this.duration += a.duration; } if(a && a.delay){ this.duration += a.delay; }
Change History (4)
comment:1 Changed 5 years ago by
Milestone: | tbd → 1.11 |
---|---|
Owner: | changed from Bryan Forbes to dylan |
Status: | new → assigned |
comment:2 Changed 5 years ago by
Priority: | undecided → low |
---|
comment:3 Changed 5 years ago by
Summary: | dojox/fx.js needs a type check to avoid error in less than IE8. → dojo/fx.js needs a type check to avoid error in less than IE8. |
---|
comment:4 Changed 5 years ago by
Milestone: | 1.11 → 1.7.9 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Fixed in:
- master https://github.com/dojo/dojo/commit/359c1e71baea11fa77cb8a530cd86aace6914c13
- 1.10 https://github.com/dojo/dojo/commit/7469d9bc103e835c00c44b2615a36fe63cd3479a
- 1.9 https://github.com/dojo/dojo/commit/c50804de484d4edb69acdb1e9d023a4498a9f434
- 1.8 https://github.com/dojo/dojo/commit/baaf7515a7590b07bfd192c7b78e8b1bd1b595e5
- 1.7 https://github.com/dojo/dojo/commit/1ca6f9d051b0d45f5da3d1191a2baf86578494c5
Note: See
TracTickets for help on using
tickets.
I hope to get to this ticket in time for 1.11 (setting a deadline of end of January). If not, this will get moved to 1.12.