Opened 7 years ago

Closed 4 years ago

#16111 closed defect (fixed)

dojo/fx.js needs a type check to avoid error in less than IE8.

Reported by: chrisacky Owned by: dylan
Priority: low Milestone: 1.7.9
Component: fx Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

This issue seems too only effect versions of Internet Explorer 7/8.

When chaining animations together, even when you set an duration, and *even* though there is a default duration on all animations, IE7/8 seems to fail when performing some animations.

Error Message:

SCRIPT5007: Unable to get value of the property 'duration': object is null or undefined fx.js, line 47 character 4

The simple fix is to add a typeof check in dojo/fx.js to make sure that duration exists.

For instance replace (on line 47):

this.duration += a.duration;
if(a.delay){ this.duration += a.delay; }

With this:

 if(a && typeof a.duration != "undefined"){
        this.duration += a.duration;
 }
 if(a && a.delay){
   this.duration += a.delay;
  }

Change History (4)

comment:1 Changed 4 years ago by dylan

Milestone: tbd1.11
Owner: changed from Bryan Forbes to dylan
Status: newassigned

comment:2 Changed 4 years ago by dylan

Priority: undecidedlow

I hope to get to this ticket in time for 1.11 (setting a deadline of end of January). If not, this will get moved to 1.12.

comment:3 Changed 4 years ago by dylan

Summary: dojox/fx.js needs a type check to avoid error in less than IE8.dojo/fx.js needs a type check to avoid error in less than IE8.
Note: See TracTickets for help on using tickets.