dojox.data.CssRuleStore can't handle remote css and @media rules

[Wouter Hager]

if css are remote, css.js runs into an infinite loop.

if CssRuleStore?._handleRule runs into @media rule an error is thrown: 'selector is null'

line 263: var selector = ruleselectorText?; var s = selector.split(" ");

Both bugs can be fixed by adding checking if null.

[Wouter Hager]

In FireFox?, CSSImportRule causes a loop in dojox/data/css.js line 96-97:

if(rule.type && rule.type === 3){ CSSImportRule (firefox)

_processSS(rule.styleSheet);

}

If the stylesheet is already added, it should not resolve again.

[dylan]

If you have a patch and cla, please post and I'll review and commit.

[trac-o-bot]

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

[Wouter Hager]

I have a patch now, please reopen and review.

[Wouter Hager]

The bug description should be expanded slightly, but it's related: if css are remote, css.js will fail.

[Wouter Hager]

Related to #17535

[Wouter Hager]

The best solution would be to rebuild this store in the new dojo/store API. Shouldn't be hard to do. I would go with xstyle, but it's too comprehensive.

[dylan]

@wshager, it might be better to rebuild the store against dstore ( ​https://github.com/sitepen/dstore ), which is the 1.x compatible but 2.x replacement for dojo/store.

If that's something you want to do, I'd suggest a pull request against that project?

[Wouter Hager]

I created a dojo css store module on ​https://github.com/wshager/dcssstore. It could be merged with dstore if so desired. Perhaps a repo for more exotic/experimental stores like currently in dojox would be better.

[dylan]

Closing since you have dcssstore. Added ​https://github.com/SitePen/dstore/issues/157 to setup a listing of community dstore instances.