Opened 7 years ago

Closed 3 years ago

#16094 closed task (patchwelcome)

dojox/calendar vs dojox/widget/Calendar

Reported by: adros Owned by: cjolif
Priority: undecided Milestone: 1.13
Component: Dojox Version: 1.8.0
Keywords: Cc: dg, cjolif
Blocked By: Blocking:

Description

New calendar widget uses same baseClass as widget/Calendar, which causes problems when both widgets are used in one page and both of theirs CSS are included.

E.g. rule .dojoxCalendar{width:182px;} (from dojox/widget/Calendar/Calendar.css) will be applied also to dojox/calendar.

I do not think that there is an easy way how to avoid this. Shouldn't one of the widgets be rewritten?

Change History (5)

comment:1 Changed 7 years ago by cjolif

Cc: dg cjolif added

comment:2 Changed 7 years ago by Adam Peller

Owner: changed from Adam Peller to cjolif
Status: newassigned

If this is a reference to Shane's calendar, that's experimental and unsupported. Code and stylesheets should probably not be shared with that widget.

comment:3 Changed 7 years ago by cjolif

Yes that's an unfortunate name clash. Unfortunately it is a bit hard to change that in a patch release without breaking the compatibility. I would suggest for now to use a workaround (i.e. change the baseClass value of one of those and query/replace in their CSS the base class). Obviously we will make sure to fix that in a new major release.

comment:4 Changed 7 years ago by bill

I'm guessing dojox/widget/Calendar won't be carried over into 2.0 so the problem will resolve itself.

comment:5 Changed 3 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: assignedclosed

Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.