Opened 7 years ago

Closed 6 years ago

#16085 closed defect (fixed)

Chrome 22: claro not correctly rendering VerticalSlider tick marks and labels

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.8.4
Component: Dijit - LnF Version: 1.8.0
Keywords: Cc: tonyerwin, bill
Blocked By: Blocking:

Description

Run test_Slider.html?theme=claro using Chrome 22 (Win 7). The first VerticalSlider?'s tick marks and labels are all over the place. Works well on IE9 and FF 15, or if using other themes like tundra.

Attachments (1)

29842-semirevert.patch (2.7 KB) - added by Brian Arnold 6 years ago.
Removes dijitInline from the slider templates, no longer necessary and causes issue in IE10

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Adam Peller

Cc: tonyerwin added

comment:2 Changed 7 years ago by bill

Owner: changed from bill to Douglas Hays
Status: newassigned

comment:3 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [29842]:

Fixes #16085. Add dijitInline and white-space:nowrap (to emulate NOBR) to VerticalSlider?'s decoration container so that child DIVs are packed in.

comment:4 Changed 7 years ago by Douglas Hays

Milestone: tbd1.8.2

comment:5 Changed 6 years ago by Brian Arnold

Cc: bill added
Milestone: 1.8.21.9
Priority: undecidedhigh
Resolution: fixed
Status: closedreopened

This fix is messing up IE10. In doing some testing, removing dijitInline from the template fixes the IE10 regression, and the current version of Chrome (25) works fine without dijitInline in play, so the updates to the test are good, but the updates to the templates should be undone.

I'm attaching a simple patch that applies cleanly against trunk as of r30884, as well as against the 1.8 branch, which removes the dijitInline class from the two relevant templates, while leaving the other changes in place. With this change, both Chrome 25 (latest stable at this point) and IE10 render just fine.

Changed 6 years ago by Brian Arnold

Attachment: 29842-semirevert.patch added

Removes dijitInline from the slider templates, no longer necessary and causes issue in IE10

comment:6 Changed 6 years ago by Douglas Hays

Milestone: 1.91.8.4
Status: reopenedassigned

comment:7 Changed 6 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [30970]:

Fixes #16085. Rollback dijitInline class insertions.

Note: See TracTickets for help on using tickets.