Opened 7 years ago

Closed 7 years ago

#16078 closed defect (fixed)

[PATCH][CCLA] dijit.form.Slider: allow users to specify aria-label

Reported by: mikeb Owned by: Douglas Hays
Priority: undecided Milestone: 1.8.2
Component: Dijit - Form Version: 1.8.0
Keywords: Cc: Douglas Hays
Blocked By: Blocking:

Description

Allows users to specify aria-label attribute that gets applied to the slider dijit (specifically the focusNode that has role="slider"). This works programmatically and declaratively. Updated the test page to be more accessible and also to utilize these attributes.

Attachments (4)

aria label for slider.patch (5.5 KB) - added by mikeb 7 years ago.
allows user to specify aria-label when creating dijit.form.Slider; fixes up the test page; please proxy commit for Michael Billau CCLA on file with IBM
test_Slider.html.patch (5.5 KB) - added by mikeb 7 years ago.
Fix test_Slider accessibility violations. It was suggested to use title attribute because screen readers currently cant read Slider labels
aria-label.patch (507 bytes) - added by Douglas Hays 7 years ago.
add aria-label to dijit/form
test_Slider.html.2.patch (5.3 KB) - added by mikeb 7 years ago.

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by mikeb

Attachment: aria label for slider.patch added

allows user to specify aria-label when creating dijit.form.Slider; fixes up the test page; please proxy commit for Michael Billau CCLA on file with IBM

comment:1 Changed 7 years ago by mikeb

Cc: Douglas Hays added

comment:2 Changed 7 years ago by mikeb

Component: GeneralDijit - Form
Owner: set to Douglas Hays

comment:3 Changed 7 years ago by mikeb

Whoops. I didn't realize there was already code in Slider to search for any <label> elements and connect those to the focusNode via aria-labelledby. aria-labelleby solution seems to work fine as long as developers remember to create an associated <label> for any programatically created Sliders.

Changed 7 years ago by mikeb

Attachment: test_Slider.html.patch added

Fix test_Slider accessibility violations. It was suggested to use title attribute because screen readers currently cant read Slider labels

Changed 7 years ago by Douglas Hays

Attachment: aria-label.patch added

add aria-label to dijit/form

comment:4 Changed 7 years ago by Douglas Hays

Milestone: tbd1.8.2
Owner: changed from Douglas Hays to mikeb
Status: newpending

mikeb, I think aria-label should be available to all dijit/form widgets, and test_Slider.html should use it.

comment:5 Changed 7 years ago by mikeb

Status: pendingnew

Hey doughays, I agree. Thanks a lot.

Changed 7 years ago by mikeb

Attachment: test_Slider.html.2.patch added

comment:6 Changed 7 years ago by Douglas Hays

Owner: changed from mikeb to Douglas Hays
Status: newassigned

comment:7 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [29811]:

Fixes #16078. Add support for aria-label on form widgets since aria-labelledby cannot always be used.

Note: See TracTickets for help on using tickets.