Opened 7 years ago

Closed 5 years ago

#16071 closed enhancement (patchwelcome)

make auto-expanding Editor's ViewSource mode also expand

Reported by: Matt Lauer Owned by:
Priority: undecided Milestone: future
Component: Editor Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

Currently it creates a standard textarea node, which is annoying and spawns textarea scrollbars often.

When using dojox.editor.plugins.PrettyPrint? with dijit._editor.plugins.ViewSource? on long html chunks, the user clicks the ViewSource? toggle and gets an awful double scroll bar effect: one for the page (normal) and one for the textarea (because PrettyPrint? beautifies the HTML w/o resizing the textarea). The textarea here is not a dijit.

It seems best that the ViewSource? plugin create a Textarea dijit instead because it is likely the user will make a change that will alter the height and normal textareas will just spawn an annoying scrollbar.

Change History (4)

comment:1 Changed 7 years ago by bill

Seems like that would only make sense if the Editor was auto-expanding?

comment:2 in reply to:  1 Changed 7 years ago by Matt Lauer

Replying to bill:

Seems like that would only make sense if the Editor was auto-expanding?

Yes, that is a good point. We use always use the Editor as an auto-expanding dijit and I forgot that is an option.

It seems like the the ViewSource? plugin could query the Editor to detect if it is auto expanding.

comment:3 Changed 7 years ago by bill

Milestone: tbdfuture
Summary: make Editor's ViewSource create a Textarea dijitmake auto-expanding Editor's ViewSource mode also expand

comment:4 Changed 5 years ago by bill

Resolution: patchwelcome
Status: newclosed

Unlikely this will be fixed unless someone wants to supply a patch (including a test case).

Note: See TracTickets for help on using tickets.