dojox/mobile/_ItemBase.onTouchStart() is running setTimeout() callback even if the widget has been destroyed

[Ed Chatelain]

_ItemBase.onTouchStart() is running setTimeout() callback even if the widget has been destroyed. In a dojox/mvc/test we had to add code to avoid a JavaScript? error in our "delete" code because this line is being called even if the item has been destroyed. this._selTimer = setTimeout(lang.hitch(this, function(){ this.set("selected", true); }), 100);

To see the problem you can update dojox/mvc/tests/mobile/demo/src.js and comment out the aspect.around(ListItem?... code, then hit dojox/mvc/tests/mobile/demo/demo.html and select the "WidgetList? Data Binding" item, then select the delete icon.

_ItemBase should be checking this so that we would not have to check it in out testcase.

[cjolif]

_WidgetBase.defer should probably be used instead of setTimeout.

[Adrian Vasiliu]

Thanks Ed for pointing it out. Once the patch will be committed, you can remove your workaround...

[ykami]

The patch looks good, thank you. One minor comment is that I wouldn't give a new line for '100);'.

[Adrian Vasiliu]

_ItemBase: avoid the risk of running the setTimeout function on destroyed widgets - Adrian Vasiliu, IBM, CCLA

[Adrian Vasiliu]

Okay, I've changed it into '}, 100);' such that it is consistent with the formatting of the this.defer in "handleSelection".

[Ed Chatelain]

In [29748]:

Fixes #16067. _ItemBase: avoid the risk of running the setTimeout function on destroyed widgets. Also remove the workaround in the dojox/mvc test since it is no longer needed. !strict Thanks Adrian Vasiliu (IBM, CCLA).

[Adrian Vasiliu]

Fix and cleanup - Adrian Vasiliu (IBM, CCLA)

[Adrian Vasiliu]

In [31203]:

refs #16067. Fix (remove extra function) and cleanup (remove useless lang.hitch). !strict