Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1604 closed defect (fixed)

ComboBox - resizes combo arrow in IE

Reported by: acirov@… Owned by: Douglas Hays
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: ComboBox, Select Cc: acirov@…
Blocked By: Blocking:

Description

Combo arrow gets resized in IE by setting width and height values, so the image appears magnified. It adds two (2) pixels to the original size. In FF it works as expected, it’s not resizing the image.

Attachments (2)

1604.patch (5.2 KB) - added by Douglas Hays 13 years ago.
updated patch removed img.complete test in ComboBox?.js to support safari
1604.2.patch (5.3 KB) - added by Douglas Hays 13 years ago.
added styling capabilities to previous patch

Download all attachments as: .zip

Change History (11)

comment:1 Changed 13 years ago by bill

Owner: changed from bill to Douglas Hays

Doug, didn't you already fix this?

comment:2 Changed 13 years ago by Douglas Hays

Cc: acirov@… added
Status: newassigned

Please verify with the attached patch.

Changed 13 years ago by Douglas Hays

Attachment: 1604.patch added

updated patch removed img.complete test in ComboBox?.js to support safari

comment:3 Changed 13 years ago by acirov@…

Better, more consistent look across various browsers.

Combo arrow should be smaller than the box itself by 1px on each side. Font size is correctly set but there should be 1px padding above and bellow the input field to make it resemble text input fields of the same size. Combo arrow should be 2px bigger than the font size, and the combo should be another 2px on the combo arrow size.

Something like: ... the ComboBox? template (ComboBox?.html, 9):

<img border="0" hspace="1" vspace="1" ...

comment:4 Changed 13 years ago by acirov@…

I did some pretty extensive testing today and the logic works perfectly. Refresh issue in FF is gone and I'm getting consistent look and feel on IE and FF. Formatting issues I mentioned in the previous post still remain of course.

Only other issues I'm experiencing are timing issues when loading external data using dojo.io.bind and setData(). Lot of Fatal errors due to access denied on parent div objects and impossibility to acquire properties from form elements.

Changed 13 years ago by Douglas Hays

Attachment: 1604.2.patch added

added styling capabilities to previous patch

comment:5 Changed 13 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [6033]) Fixes #1604 #1600

comment:6 Changed 13 years ago by Douglas Hays

The padding/margin issues are user-defined. Just set padding when you create a ComboBox/Select? widgets to make space inside the border. Margin can also be used to add space outside of the border.

comment:7 Changed 13 years ago by acirov@…

Manually setting padding and margins doesn't work in IE, because of the non standard way IE calculates these parameters. It doesn't add them to the existing size. Resizing of the ComboBox? would be required.

comment:8 Changed 13 years ago by acirov@…

Sorry, my mistake. Works perfectly. I just made a stupid mistake while patching the CSS file.

comment:9 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.