Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16035 closed defect (fixed)

dojo/dnd/move.parentConstrainedMoveable classname misses the 'dojo' prefix

Reported by: Patrick Ruzand Owned by: Eugene Lazutkin
Priority: undecided Milestone: 1.8.1
Component: DnD Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

dojo/dnd/move.parentConstrainedMoveable classname misses the 'dojo' prefix which breaks backward compat.

It's due to changes [28517] in dojo/dnd/move.js, where the classname of the parentConstrainedMoveable class declaration misses its "dojo" prefix.

Should be:

var parentConstrainedMoveable = declare("dojo.dnd.move.parentConstrainedMoveable", constrainedMoveable, {

see #14980

You can see the error by loading demos/cropper/demo.html that throws the following error:

TypeError: d.dnd.move.parentConstrainedMoveable is not a constructor
http://../demos/cropper/src/Preview.js
Line 107

Change History (5)

comment:1 Changed 7 years ago by Patrick Ruzand

Resolution: fixed
Status: newclosed

In [29685]:

fix parentConstrainedMoveable class declaration for backward compat (missed dojo prefix). fixes #16035

comment:2 Changed 7 years ago by Patrick Ruzand

Milestone: tbd1.9

comment:3 Changed 7 years ago by bill

Description: modified (diff)

Thanks for the fix, can you check it into the 1.8 branch too?

Last edited 7 years ago by bill (previous) (diff)

comment:4 Changed 7 years ago by Patrick Ruzand

In [29687]:

backport to 1.8 branch: fix parentConstrainedMoveable class declaration for backward compat (missed dojo prefix). refs #16035

comment:5 Changed 7 years ago by Patrick Ruzand

Milestone: 1.91.8.1
Note: See TracTickets for help on using tickets.