Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16029 closed defect (fixed)

[regression] mdnd test failure in test_dnd_dndFromDojo.html, included patch

Reported by: wsargent Owned by: Adam Peller
Priority: undecided Milestone: 1.8.2
Component: Dojox Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

When you run the test by hitting the page, you cannot accept Type1 items into the "Source/Target? dojox" box, and you see the exception as follows:

Uncaught TypeError?: Object #<Object> has no method 'manager' at line 51 in DndFromDojo?.js.

Attachments (1)

DndFromDojo.patch (1.0 KB) - added by wsargent 7 years ago.
patch to change Manager reference

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by wsargent

Attachment: DndFromDojo.patch added

patch to change Manager reference

comment:1 Changed 7 years ago by Adam Peller

patch file does not apply. what format is this?

I'm not familiar with the code. Why isn't a 'new' keyword needed here? Why not also convert over the AreaManager? line above?

comment:2 Changed 7 years ago by bill

Milestone: tbd1.8.2

manager() and areaManager() are both factory functions, hence no new keyword.

I'll check in the fix to call Manager.manager() along with the fix to #16036. Can't call AreaManager.areaManager() though without fixing the code in dojox/dnd/AreaManager.js, so I won't bother with that. (You can update it if you like.)

comment:3 Changed 7 years ago by bill

In [29755]:

For back-compat, make sure client code can call dojox.dnd.manager() in addition to Manager.manager(). Also fixing one of the AMD conversion errors in dojox/mdnd. Refs #16029, #16036, !strict, fixing them on trunk.

comment:4 Changed 7 years ago by bill

Resolution: fixed
Status: newclosed

In [29807]:

Merge [29755] to 1.8 branch, making dojox.dnd.manager() available again, fixes #16029, #16036 !strict.

comment:5 Changed 7 years ago by bill

Summary: mdnd test failure in test_dnd_dndFromDojo.html, included patch[regression] mdnd test failure in test_dnd_dndFromDojo.html, included patch
Note: See TracTickets for help on using tickets.