Opened 8 years ago
Closed 8 years ago
#16027 closed defect (fixed)
[PATCH][CCLA] dijit.form.CheckBox - remove superfluous aria attributes
Reported by: | mikeb | Owned by: | mikeb |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8.2 |
Component: | Dijit - Form | Version: | 1.8.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
dijit.form.CheckBox? has aria role="presentation" but uses aria-checked attribute. Aria-checked attribute is not a global aria attribute and can only be used on specific roles. To fix this I have decided it is best to remove the aria-checked attribute instead of changing the role to role=checkbox. This is because the WAI-ARIA spec states that WAI-ARIA should not be used as a replacement of normal HTML semantics.(http://www.w3.org/TR/wai-aria/introduction#co-evolution)
Patch also updates the test pages for CheckBox? and Button (needed to check ToggleButton?)
Attachments (3)
Change History (7)
Changed 8 years ago by
Attachment: | Checkbox.patch added |
---|
comment:1 Changed 8 years ago by
Milestone: | tbd → 1.8.2 |
---|
comment:2 Changed 8 years ago by
Owner: | changed from Douglas Hays to mikeb |
---|---|
Status: | new → pending |
mikeb, please test with the attached 16027.patch that adds role=checkbox to see if the violations are gone, and also check dojox/form/TriStateCheckBox since it inherits.
Changed 8 years ago by
Attachment: | 16027.patch added |
---|
proposed fix with role=checkbox added plus TriStateCheckBox fixes
comment:3 Changed 8 years ago by
Status: | pending → new |
---|
doughays, I tested out the patch and it worked really well for CheckBox?. I had to make one slight change to TriStateCheckBox? (set _aria_attr: "aria-checked",
because it was setting aria-pressed instead.) I also removed the aria-readonly from TriStateCheckbox? because that is invalid and updated the test page.
Changed 8 years ago by
Attachment: | 16027-2.patch added |
---|
set _aria_attr so that TriStateCheckbox? sets aria-checked, remove aria-readonly from TriStateCheckbox?, update test page
removes aria-checked attribute from dijit.form.Checkbox since it has no aria role; updates test pages; please proxy commy for michael billau ccla on file with IBM