Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#15995 closed defect (fixed)

android-webdriver-robot.js build error with closure compiler

Reported by: lee Owned by: haysmark
Priority: high Milestone: 1.9
Component: TestFramework Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

I've checked out trunk dojo and ran a build profile with copyTests:true and optimise:"closure".

copyTests adds doh to the build control packages, when using the closure compiler the build breaks at ​http://bugs.dojotoolkit.org/browser/dojo/util/trunk/doh/plugins/android-webdriver-robot.js#L165 for an un-declared variable (top.console - there are other references to top).

I'm not sure what it's supposed to be assigned to (something in selenium runtime?) but it breaks an optimised layer build e.g. the layer just contains 

//>>built

the uncompressed layer builds fine

Change History (6)

comment:1 in reply to:  description Changed 8 years ago by lee

I realised top is the iframe parent reference for the doh runner but it'll still break the build

Last edited 8 years ago by lee (previous) (diff)

comment:2 Changed 8 years ago by bill

Owner: set to haysmark
Status: new → assigned

comment:3 Changed 8 years ago by haysmark

Yes I'm sure those top.console statements can go...

comment:4 Changed 8 years ago by haysmark

Resolution: → fixed
Status: assigned → closed

In [29683]:

Remove debug log statements that were breaking the build. Fixes #15995.

comment:5 Changed 8 years ago by haysmark

Milestone: tbd → 1.9
Priority: undecided → high

comment:6 Changed 8 years ago by haysmark

In [29751]:

Fix robot automatic scrolling on mobile. Fix stupid HTML errors in the mobileRunner. Refs #15995.

Note: See TracTickets for help on using tickets.