Opened 7 years ago

Closed 7 years ago

#15985 closed defect (invalid)

Wrong display of mirrored StackContainer on widjit level

Reported by: ahmedasaleh Owned by: ahmedasaleh
Priority: undecided Milestone: tbd
Component: Dijit Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

Using the file StackContainer?.html to test the BIDI support for the StackContainer?, it found that dijit.layout.StackContainer? is not mirrored correctly when dir is specified on dojo level.

Attachments (3)

stackContainer.JPG (44.0 KB) - added by ahmedasaleh 7 years ago.
Wrong display of mirrored dijit.layout.StackContainer? when dir is specified on widget level
StackContainer.js.patch (627 bytes) - added by Douglas Hays 7 years ago.
patch from Hossam Katory (IBM, CCLA)
StackController.js.patch (1.2 KB) - added by Douglas Hays 7 years ago.
patch from Hossam Katory (IBM, CCLA)

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by ahmedasaleh

Attachment: stackContainer.JPG added

Wrong display of mirrored dijit.layout.StackContainer? when dir is specified on widget level

comment:1 Changed 7 years ago by bill

I'm really not sure what you mean. According to your screenshot you are talking about the StackController, not the StackContainer. Did you specify dir=rtl on the StackContainer, StackController, or on the whole page? Please attach your test case.

comment:2 Changed 7 years ago by ahmedasaleh

Herein the changes I made to the widjit in the body, I added the property dir="rtl" and expected the StackController? to change accordingly

	<div dir="rtl" id="myStackContainer" data-dojo-type="dijit/layout/StackContainer"
		data-dojo-props='style:"width: 90%; border: 1px solid #9b9b9b; height: 20em; margin: 0.5em 0 0.5em 0; padding: 0.5em;"'>
		<p id="page1" data-dojo-type="dijit/layout/ContentPane" data-dojo-props='title:"page 1"'>IT WAS the best of times, it <input value="was the worst" /> of times, it was the age of wisdom, it was the age of foolishness, it was the epoch of belief, it was the epoch of incredulity, it was the season of Light, it was the season of Darkness, it was the spring of hope, it was the winter of despair, we had everything before us, we had nothing before us, we were all going direct to Heaven, we were all going direct the other way -- in short, the period was so far like the present period, that some of its noisiest authorities insisted on its being received, for good or for evil, in the superlative degree of comparison only</p>
		<p id="page2" data-dojo-type="dijit/layout/ContentPane" data-dojo-props='title:"page 2"'>There were a king with a large jaw and a queen with a plain face, on the throne of England; there were a king with a large jaw and a queen with a fair face, on the throne of <a href="http://www.france.com">France</a>. In both countries it was clearer than crystal to the lords of the State preserves of loaves and fishes, that things in general were settled for ever.</p>
		<p id="page3" data-dojo-type="dijit/layout/ContentPane" data-dojo-props='title:"page 3"'>It was the year of Our Lord one thousand seven hundred and seventy- five. Spiritual revelations were conceded to England at that favoured period, as at this. Mrs. Southcott had recently attained her five-and- twentieth blessed birthday, of whom a prophetic private in the Life Guards had heralded the sublime appearance by announcing that arrangements were made for the swallowing up of London and Westminster. Even the Cock-lane ghost had been laid only a round dozen of years, after rapping out its messages, as the spirits of this very year last past (supernaturally deficient in originality) rapped out theirs. Mere messages in the earthly order of events had lately come to the English Crown and People, from a congress of British subjects in America:</p>
	</div>

comment:3 Changed 7 years ago by bill

Owner: changed from bill to ahmedasaleh
Status: newpending

Oh OK, well actually, unlike TabContainer, the StackController is an independent widget from the StackContainer, so if you want the StackController to be RTL then you need to set dir=rtl on the StackController.

So sounds like there's no issue, although you should double check that setting dir on the StackController works.

Changed 7 years ago by Douglas Hays

Attachment: StackContainer.js.patch added

patch from Hossam Katory (IBM, CCLA)

Changed 7 years ago by Douglas Hays

Attachment: StackController.js.patch added

patch from Hossam Katory (IBM, CCLA)

comment:4 Changed 7 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.