Opened 7 years ago

Closed 6 years ago

#15979 closed defect (fixed)

extra space exists in mirrored Editor

Reported by: ahmedasaleh Owned by: bill
Priority: undecided Milestone: 1.9
Component: Editor Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

Using the test_Editor.html file to test the BIDI support for the Editor, it found that there are Extra spaces are added in mirrored dijit.Editor

Attachments (2)

extra_spaces.JPG (59.4 KB) - added by ahmedasaleh 7 years ago.
Extra spaces are added in mirrored dijit.Editor
Editor_rtl.css.patch (634 bytes) - added by Douglas Hays 7 years ago.
patch from Hossam Katory (IBM, CCLA)

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by ahmedasaleh

Attachment: extra_spaces.JPG added

Extra spaces are added in mirrored dijit.Editor

comment:1 Changed 7 years ago by ahmedasaleh

This problem appears in IE browser, FF and Chrome are OK.

Changed 7 years ago by Douglas Hays

Attachment: Editor_rtl.css.patch added

patch from Hossam Katory (IBM, CCLA)

comment:2 Changed 6 years ago by bill

Milestone: tbd1.9
Owner: set to bill
Status: newassigned

comment:3 Changed 6 years ago by bill

About the change to the general editor CSS:

.claro .dijitEditorRtl .dijitEditorIFrameContainer {
  /*padding: 3px 10px 1px 3px;*/ /*removed by IBM*/
  padding: 3px 3px 1px 10px; /*Added by IBM*/
}

It seems bad, because with the current CSS, both the LTR and RTL editors have a 10px margin before the text. After your change, the RTL editor only has a 3px margin. This is inconsistent. (Tested on mac/chrome.)

About the new rule you added for IE:

.dj_ie .claro .dijitEditorRtl .dijitEditorIFrameContainer {
  padding: 3px 0px 1px 10px;
  margin-right: 0px;
  border: 0px solid #d3d3d3;

It's too general because it affects IE9 too, when IE9 is already working fine. But I will modify it to only affect IE6-8.

comment:4 Changed 6 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29893]:

Fix right margin in Editor in RTL mode on IE6, IE7, IE8, based on patch from Hossam Katory (IBM, CCLA), thanks, fixes #15979.

Note: See TracTickets for help on using tickets.