Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15978 closed defect (fixed)

color pallete plugin not mirrored when dir=rtl specified on Editor

Reported by: ahmedasaleh Owned by: Jared Jurkiewicz
Priority: undecided Milestone: 1.8.1
Component: Editor Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

Using the test_Editor.html file to test the BIDI support for the Editor plugins, it found that Color Palette Plugin is not mirrored when dir is specified on dijit.Editor widget level.

Attachments (1)

colorpallete.JPG (37.0 KB) - added by ahmedasaleh 7 years ago.
Color Palette is not mirrored when dir is specified on dijit.Editor widget level

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by ahmedasaleh

Attachment: colorpallete.JPG added

Color Palette is not mirrored when dir is specified on dijit.Editor widget level

comment:1 Changed 7 years ago by bill

Summary: color pallete plugin not mirroredcolor pallete plugin not mirrored when dir=rtl specified on Editor

comment:2 Changed 7 years ago by bill

The real issue is the inconsistency, that plain ColorPalette are mirrored, but not when part of the Editor.

comment:3 Changed 7 years ago by Jared Jurkiewicz

Owner: set to Jared Jurkiewicz
Resolution: fixed
Status: newclosed

In [29671]:

Minor tweak to instantiation of basic color selector to pass on rtl fixes #15978

comment:4 Changed 7 years ago by Jared Jurkiewicz

In [29672]:

Minor tweak to instantiation of basic color selector to pass on rtl fixes #15978

comment:5 Changed 7 years ago by Jared Jurkiewicz

Milestone: tbd1.8.1

comment:6 Changed 7 years ago by bill

Hi Jared -

Any reason you didn't do like below?

dir: self.editor.dir

That's how it's done in other code. Your way seems unnecessarily complicated and will also presumably fail in some corner cases, like when the machine default is RTL but the editor overrides it with a dir=ltr setting.

comment:7 Changed 7 years ago by Jared Jurkiewicz

In [29674]:

Use Bill's suggested way instead of calling directional test API. refs #15978

comment:8 Changed 7 years ago by Jared Jurkiewicz

In [29675]:

Use Bill's suggested way instead of calling directional test API. refs #15978

comment:9 Changed 7 years ago by Jared Jurkiewicz

I did it the first way originally because I wasn't sure testing the property directly was safe (since there already was an API for testing directionality.) In any event, if you say the other is safe and the common way, cool. I changed it to that.

Note: See TracTickets for help on using tickets.