#15978 closed defect (fixed)
color pallete plugin not mirrored when dir=rtl specified on Editor
Reported by: | ahmedasaleh | Owned by: | Jared Jurkiewicz |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8.1 |
Component: | Editor | Version: | 1.8.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Using the test_Editor.html file to test the BIDI support for the Editor plugins, it found that Color Palette Plugin is not mirrored when dir is specified on dijit.Editor widget level.
Attachments (1)
Change History (10)
Changed 10 years ago by
Attachment: | colorpallete.JPG added |
---|
comment:1 Changed 10 years ago by
Summary: | color pallete plugin not mirrored → color pallete plugin not mirrored when dir=rtl specified on Editor |
---|
comment:2 Changed 10 years ago by
The real issue is the inconsistency, that plain ColorPalette are mirrored, but not when part of the Editor.
comment:3 Changed 10 years ago by
Owner: | set to Jared Jurkiewicz |
---|---|
Resolution: | → fixed |
Status: | new → closed |
In [29671]:
comment:5 Changed 10 years ago by
Milestone: | tbd → 1.8.1 |
---|
comment:6 Changed 10 years ago by
Hi Jared -
Any reason you didn't do like below?
dir: self.editor.dir
That's how it's done in other code. Your way seems unnecessarily complicated and will also presumably fail in some corner cases, like when the machine default is RTL but the editor overrides it with a dir=ltr setting.
comment:9 Changed 10 years ago by
I did it the first way originally because I wasn't sure testing the property directly was safe (since there already was an API for testing directionality.) In any event, if you say the other is safe and the common way, cool. I changed it to that.
Color Palette is not mirrored when dir is specified on dijit.Editor widget level