color pallete plugin not mirrored when dir=rtl specified on Editor

[ahmedasaleh]

Using the test_Editor.html file to test the BIDI support for the Editor plugins, it found that Color Palette Plugin is not mirrored when dir is specified on dijit.Editor widget level.

[ahmedasaleh]

Color Palette is not mirrored when dir is specified on dijit.Editor widget level

[bill]

The real issue is the inconsistency, that plain ColorPalette are mirrored, but not when part of the Editor.

[Jared Jurkiewicz]

In [29671]:

Minor tweak to instantiation of basic color selector to pass on rtl fixes #15978

[Jared Jurkiewicz]

In [29672]:

Minor tweak to instantiation of basic color selector to pass on rtl fixes #15978

[bill]

Hi Jared -

Any reason you didn't do like below?

dir: self.editor.dir

That's how it's done in other code. Your way seems unnecessarily complicated and will also presumably fail in some corner cases, like when the machine default is RTL but the editor overrides it with a dir=ltr setting.

[Jared Jurkiewicz]

In [29674]:

Use Bill's suggested way instead of calling directional test API. refs #15978

[Jared Jurkiewicz]

In [29675]:

Use Bill's suggested way instead of calling directional test API. refs #15978

[Jared Jurkiewicz]

I did it the first way originally because I wasn't sure testing the property directly was safe (since there already was an API for testing directionality.) In any event, if you say the other is safe and the common way, cool. I changed it to that.