Opened 7 years ago

Closed 7 years ago

#15972 closed defect (fixed)

Undefined variables referenced in dojox.editor.plugins.NormalizeStyle

Reported by: mattwood0 Owned by: Jared Jurkiewicz
Priority: undecided Milestone: 1.8.1
Component: Editor Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

There are two variables in dojox.editor.plugins.NormalizeStyle? that are used without being defined, breaking its functionality. Since they seemed related I only opened up one ticket, but I can open one up for each if needed.

The first affects all browsers. To reproduce:

  • Set up a dijit.Editor using the NormalizeStyle? plugin
  • Open up a document (like in a Word Processor) and get some text that is different from your stand font size. I used 16pt
  • Copy the text from the document into the editor
  • Click out of the editor
  • The error in the console should be something like: Uncaught ReferenceError?: font is not defined

The second affects IE (tested in IE7 and IE9). To reproduce:

  • Set up a dijit.Editor using the NormalizeStyle? plugin
  • Click bold
  • Type any text
  • Click out of the editor
  • Error in the console should be: 'doc' is undefined

I'll attach a patch that fixes these two issues as well as the test page I was using. You'll need to point the script and css tags to the correct location.

I submitted a CCLA on 9-12-2012 for Idea Works as Matt Wood.

Attachments (2)

normalizeStyleFix.patch (734 bytes) - added by mattwood0 7 years ago.
editor_test.html (571 bytes) - added by mattwood0 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by mattwood0

Attachment: normalizeStyleFix.patch added

Changed 7 years ago by mattwood0

Attachment: editor_test.html added

comment:1 Changed 7 years ago by Jared Jurkiewicz

In [29669]:

Fixing issue in NormalizeStyle? plugin conversion to AMD. refs #15972

comment:2 Changed 7 years ago by Jared Jurkiewicz

Milestone: tbd1.8.1

comment:3 Changed 7 years ago by Jared Jurkiewicz

Owner: set to Jared Jurkiewicz
Resolution: fixed
Status: newclosed

In [29670]:

Fixing issue in NormalizeStyle? plugin conversion to AMD. fixes #15972

Note: See TracTickets for help on using tickets.