Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15970 closed defect (fixed)

dojox/mobile/tests/test_theme-switch.html: on phones, impossible to test some themes

Reported by: Adrian Vasiliu Owned by: Eric Durocher
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

This is an issue within the "Dynamic Theme Switch" test of dojox.mobile (dojox/mobile/tests/test_theme-switch.html):

The test contains a toolbar inside a Heading, with tabs for each of the 5 mobile themes (iPhone, iPad, Android, BlackBerry, and custom). Now, on phones, some of the tabs don't fit the screen width hence can't be touched. For instance, on iPhone 4S, in portrait orientation only the iPhone and iPad tabs can be accessed. Turning the phone in landscape orientation shows more tabs, but the "custom" tab is still inaccessible.

The attached patch contains a modified CSS in the test such that all tabs are always accessible. (In the longer run, it may be nice to make it easier for users to get a compact display of toolbars without needing to dig into the CSS. However, there will always be cases when all tabs don't fit the screen width, and these cases shouldn't necessarily be treated by default by forcing a second row of tabs - this is an application design issue.)

Attachments (1)

patch15970.patch (2.3 KB) - added by Adrian Vasiliu 7 years ago.
Modified CSS in the test such that all themes can be tested on small screens (phones) - Adrian Vasiliu, IBM, CCLA

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Adrian Vasiliu

Attachment: patch15970.patch added

Modified CSS in the test such that all themes can be tested on small screens (phones) - Adrian Vasiliu, IBM, CCLA

comment:1 Changed 7 years ago by cjolif

Resolution: fixed
Status: newclosed

In [29680]:

fixes #15970. Modified CSS in the test such that all themes can be tested on small screens (phones) - Thanks Adrian Vasiliu (IBM, CCLA).

comment:2 Changed 7 years ago by cjolif

Milestone: tbd1.9
Note: See TracTickets for help on using tickets.