Opened 13 years ago

Closed 12 years ago

#1597 closed enhancement (fixed)

Drag and drop fails to scroll the window

Reported by: ghendricks@… Owned by: Eugene Lazutkin
Priority: high Milestone: 1.2
Component: DnD Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Eugene Lazutkin)

I am not sure if anything can be done about this in dojo or if this is something that needs to be addressed in Firefox.

I have a tree (not TreeV3 but I think it applies there too) that I am dragging elements from to another tree, there are enough nodes that, when expanded, the source tree is larger than the window viewing area. If I scroll down, I can no longer see the target tree. When I drag to the top of the window I expect it to start scrolling up. It does not however.

I have been able to work around this by hitting page up on my keyboard. This causes the image of the thing I am dragging to be offset from the mouse cursor by the distance I scrolled however.

I am running Dojo svn tip on Firefox 1.5.0.6

Change History (15)

comment:1 Changed 13 years ago by bill

Milestone: 0.6

yes, this would certainly be a nice feature; not sure if it's a DnD feature or a tree feature.

comment:2 Changed 12 years ago by bill

Component: WidgetsDnD
Owner: changed from bill to Eugene Lazutkin

Passing to Eugene for consideration. I think auto-scrolling would be a nice feature.

comment:3 Changed 12 years ago by Eugene Lazutkin

Status: newassigned

comment:4 Changed 12 years ago by Eugene Lazutkin

Additional requirements from Ben Lowery:

  • constrain the move to the document body
  • on any of the above, scroll the document when you get within n pixels of the edge of the viewport

comment:5 Changed 12 years ago by Eugene Lazutkin

Type: defectenhancement

comment:6 Changed 12 years ago by Eugene Lazutkin

Milestone: 1.00.9

comment:7 Changed 12 years ago by bill

I also thought we should scroll whatever div you are over (assuming that it's overflow: scroll and has a scrollbar. Like in a mail application with a tree on the LHS with it's own scrollbar...

comment:8 Changed 12 years ago by Eugene Lazutkin

Resolution: fixed
Status: assignedclosed

(In [9372]) Implemented autoscroll. Tested on FF, IE, Op, and Safari -- the last two suffer from giblets --- probably need to file bugs to them. Implemented a condenced version of getViewport(). It is quite small --- probably it should go to html.js. Fixes #1597.

comment:9 Changed 12 years ago by Eugene Lazutkin

Just noticed the last bill's note about scrolling divs. Probably it should be another enhancement ticket --- need more info and more research to do that. As always patches are welcomed!

comment:10 Changed 12 years ago by Eugene Lazutkin

Resolution: fixed
Status: closedreopened

Reopened to address Bill's additional enhancement request.

comment:11 Changed 12 years ago by Eugene Lazutkin

(In [9406]) Refactored autoscroll, minor cleanup. Implemented dojo.dnd.autoScrollNodes(), but at the moment it works only on FF --- apparently dojo.html methods do not isolate us good enough from idiosyncrasies of different browsers. Will investigate more. For the new method is not used anywhere. Refs #1597.

comment:12 Changed 12 years ago by Eugene Lazutkin

Milestone: 0.91.0

The current implementation scrolls window. Of course it will be nice to scroll all scrollable objects, but it is not a major problem at the moment. Bumping it up to 1.0.

comment:13 Changed 12 years ago by Eugene Lazutkin

Milestone: 1.01.1

comment:14 Changed 12 years ago by Eugene Lazutkin

Milestone: 1.11.2

comment:15 Changed 12 years ago by Eugene Lazutkin

Description: modified (diff)
Resolution: fixed
Status: reopenedclosed

The Trac hook is acting up, so I am closing this ticket manually as fixed today.

Note: See TracTickets for help on using tickets.