Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#15966 closed defect (fixed)

TimePicker: should never show just up/down arrows and no times

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: undecided Milestone: 1.8.2
Component: Dijit Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:


When using TimeTextBox, if an invalid date is typed, the TimePicker just shows the up and down arrows and no items. This is less than helpful since the user doesn't understand the format.

Change History (5)

comment:1 Changed 7 years ago by Douglas Hays

Owner: changed from bill to Douglas Hays
Status: newassigned

comment:2 Changed 7 years ago by Paul Christopher

Moreover there is also no easy way to keep a TimeTextBox from opening the drop down when typing, see TimeTextBox.js line 45 et seq. You need to create your own TimeTextBox by copying the whole code and fix the _onKey stuff (I could not find a way to solve that by inheritance).

In contrast a DateTextBox never opens when typing. In my last project I had to fix this issue so as to make DateTextBox and TimeTextBox behave the same way, i.e. not to open the drop down when clicking and typing.

comment:3 Changed 7 years ago by Douglas Hays

Milestone: tbd1.8.2

The opening of the dropdown is probably a tangent discussion. TimeTextBox has a search capability that DateTextBox does not (kind of like ComboBox) and thus this is why the dropdown always shows up.

Last edited 7 years ago by Douglas Hays (previous) (diff)

comment:4 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [29821]:

Fixes #15966. If TimePicker has no times to display because of the entered filter text, then show entries assuming no filter to assist the end-user in choosing a valid time.

comment:5 Changed 6 years ago by bill

In [30660]:

The comment in the test claims that typing "12a" will filter to entries starting with "12", but that's not what happens, nor is it what the test is checking. If it were, there would be 8 entries, not 10, and the test checks for 10. So, changing comment. Refs #15966.

Note: See TracTickets for help on using tickets.