Opened 7 years ago

Closed 7 years ago

#15965 closed defect (fixed)

dojox/mobile/Accordion: usability issue in "fixed height" mode (can't collapse an open pane by touching its title)

Reported by: Adrian Vasiliu Owned by: Eric Durocher
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

The dojox/mobile/Accordion has three modes: "fixedHeight", "singleOpen", and the default mode. In all modes but the "fixedHeight" one, clicking/touching the title of an expanded pane closes it. Now, this creates usability troubles:

1/ Semantic inconsistency. What would be a good reason an open pane wouldn't close when touching its title just because it has the "fixedHeight" setting? According to its doc, the "fixedHeight" mode only concerns the sizing of the accordion, and it looks unexpected for the user that it influences the way the panes are open/closed.

2/ Unconfortable interaction on mobile devices. Example: Load dojox/mobile/tests/test_Accordion-demo.html on iPhone (say, in portrait orientation). Switch to the "Fixed" tab. Touch the title of the "ScrollableView" pane. Now this pane is open. Try to open a different pane: this is hard to achieve, because for that you need to touch the title of a different pane, and for that you need to scroll, but most of the screen is now covered by the ScrollableView thus the scroll gesture doesn't scroll the page but the content of the pane...

All in one, I think it is better to allow the collapsing of an open pane by touching its title, in "fixedHeight" mode just as in the other modes. This simple change is in the attached patch.

Attachments (2)

patch15965.patch (583 bytes) - added by Adrian Vasiliu 7 years ago.
Accordion in fixedHeight mode: allow collapse of open pane by touching/clicking its title - Adrian Vasiliu, IBM, CCLA
patch15965-new.patch (2.0 KB) - added by Adrian Vasiliu 7 years ago.
Reduced the fixedHeight specification in the test to avoid the usability issue (difficulty to open a different pane when the open one contains a scrollable view; now the title of a second pane is visible on iPhone). Small addition to the doc of Accordion.fixedHeight to mention the impact of this mode on the way expand/collapse works. - Adrian Vasiliu, IBM, CCLA

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by Adrian Vasiliu

Attachment: patch15965.patch added

Accordion in fixedHeight mode: allow collapse of open pane by touching/clicking its title - Adrian Vasiliu, IBM, CCLA

Changed 7 years ago by Adrian Vasiliu

Attachment: patch15965-new.patch added

Reduced the fixedHeight specification in the test to avoid the usability issue (difficulty to open a different pane when the open one contains a scrollable view; now the title of a second pane is visible on iPhone). Small addition to the doc of Accordion.fixedHeight to mention the impact of this mode on the way expand/collapse works. - Adrian Vasiliu, IBM, CCLA

comment:1 Changed 7 years ago by Adrian Vasiliu

Got Eric's advice that it would be preferable to preserve the current behavior: in fixedHeight mode you can collapse a pane only by opening a different one. Hence, attached a new patch which simply adjusts the test such that it works better on iPhone and other small screens (plus a doc addition for Accordion.fixedHeight).

comment:2 Changed 7 years ago by cjolif

Milestone: tbd1.9

I agree with Eric we should keep it as is for now otherwise this would prevent users that want to force always one pane to be open to do that. That said in 2.0 I think we should revisit this as this is indeed not very explicit. We should probably manage the size and the fact we want to force or not a pane to always be open as separate things.

comment:3 Changed 7 years ago by cjolif

Resolution: fixed
Status: newclosed

In [29681]:

Fixes #15965. Reduced the fixedHeight specification in the test to avoid the usability issue (difficulty to open a different pane when the open one contains a scrollable view; now the title of a second pane is visible on iPhone). Small addition to the doc of Accordion.fixedHeight to mention the impact of this mode on the way expand/collapse works. Thanks Adrian Vasiliu (IBM, CCLA).

Note: See TracTickets for help on using tickets.