Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15960 closed defect (fixed)

[patch][ccla] Dijit.ColorPalette: missing aria role='row' on _PaletteMixin

Reported by: mikeb Owned by: bill
Priority: undecided Milestone: 1.8.4
Component: Dijit Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

ColorPalette (and anything else that uses _PaletteMixin) correctly has the aria roles "grid" and "gridcell" but is missing the role="row".

Also fixed up the text page for ColorPalette?

Attachments (1)

colroPalette.patch (2.7 KB) - added by mikeb 7 years ago.
adds missing role=row to _PaletteMixin, fixes up ColorPalette? test page; please proxiy commit for michael billau, CCLA on file with IBM

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by mikeb

Attachment: colroPalette.patch added

adds missing role=row to _PaletteMixin, fixes up ColorPalette? test page; please proxiy commit for michael billau, CCLA on file with IBM

comment:1 Changed 7 years ago by bill

Component: GeneralDijit
Owner: set to bill

comment:2 Changed 7 years ago by bill

Description: modified (diff)
Milestone: tbd1.9

I was wondering if we need any of those roles specified, since it's already using <table>, <tr> and <td> nodes, but I guess so according to http://www.w3.org/TR/wai-aria/complete#grid, since it's an interactive table rather than just a plain data table. I'll check in, thanks.

comment:3 Changed 7 years ago by bill

Resolution: fixed
Status: newclosed

In [29892]:

Missing aria role for ColorPalette. Patch from Mike Billau (IBM, CCLA), thanks. Fixes #15960 !strict.

comment:4 Changed 7 years ago by Douglas Hays

In [30315]:

Refs #15960, #16274, #16353. Backport [29892], [29905], [29981] to 1.8.

comment:5 Changed 7 years ago by Douglas Hays

Milestone: 1.91.8.4
Note: See TracTickets for help on using tickets.