Changes between Initial Version and Version 1 of Ticket #15958, comment 6


Ignore:
Timestamp:
Sep 14, 2012, 4:08:46 PM (7 years ago)
Author:
cjolif
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15958, comment 6

    initial v1  
    1 I started looking at the patches and committed some. Thanks. Looking at the code I have some doubts about your modifications to plot2d/common.js. Looks like you are in some cases you are now always comparing new potential min/max with the old min/max value (before the iteration) while before it was compared with the "live" value (updated at each iteration). Am I missing something or have you done more than removing dead code here? (and created a potential issue).
     1I started looking at the patches and committed some. Thanks. Looking at the code I have some doubts about your modifications to plot2d/common.js. Looks like you you are now in some cases comparing new potential min/max with the old min/max value (before the iteration) while before it was compared with the "live" value (updated at each iteration). Am I missing something or have you done more than removing dead code here? (and created a potential issue).