#15942 closed defect (fixed)
ProgressBar: misplaced border when direction is RTL
| Reported by: | Alia Naguib | Owned by: | bill |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.9 |
| Component: | Dijit | Version: | 1.6.0 |
| Keywords: | Cc: | Douglas Hays | |
| Blocked By: | Blocking: |
Description
Locale: English Browsers: IE8/Windows 7, FF10/Windows 7, FF10/Linux, Safari/MacOS
Procedure:
1- Set the direction for the widget to right to left. (Use dir="rtl")
Actual Result:
- The closing end of the progress bar is missing
Expected Result:
- When the direction of the widget is left to Right (LTR), the closing end of the progress bar has a bold border. This border is placed on the right end.
- On setting the direction to be right to left (RTL), the closing end should also have this bold border. In this case it is placed on the left end.
Attachments (7)
Change History (14)
Changed 8 years ago by
| Attachment: | progressBar_defect.jpg added |
|---|
comment:1 Changed 8 years ago by
| Component: | General → Dijit |
|---|---|
| Milestone: | tbd → 1.9 |
| Owner: | set to bill |
| Summary: | Misplaced progress bar border when direction is RTL → ProgressBar: misplaced border when direction is RTL |
comment:2 Changed 8 years ago by
| Cc: | Douglas Hays added |
|---|---|
| Owner: | changed from bill to Alia Naguib |
| Status: | new → pending |
Where are the ProgressBar_rtl.css files? The patches reference them but they don't exist.
Changed 8 years ago by
| Attachment: | ProgressBar_rtl.patch added |
|---|
comment:3 Changed 8 years ago by
| Status: | pending → new |
|---|
Attachment (ProgressBar_rtl.patch) added by ticket reporter.
comment:4 Changed 8 years ago by
| Owner: | changed from Alia Naguib to bill |
|---|---|
| Status: | new → assigned |
OK thanks. I'll need to make a few modifications:
- There's no need to list the color in the RTL files; it's better to just reset the border width. Then if users customize the theme they only have to change the color in one place.
- I see there's no dijitProgressBarRtl class so you worked around that in the RTL file, but not perfectly, because a
new ProgressBar({dir: "ltr"})inside of an RTL page will incorrectly switch to RTL style.
Note: See
TracTickets for help on using
tickets.
This attached image shows the progress bar defect