Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#15942 closed defect (fixed)

ProgressBar: misplaced border when direction is RTL

Reported by: Alia Naguib Owned by: bill
Priority: undecided Milestone: 1.9
Component: Dijit Version: 1.6.0
Keywords: Cc: Douglas Hays
Blocked By: Blocking:

Description

Locale: English Browsers: IE8/Windows 7, FF10/Windows 7, FF10/Linux, Safari/MacOS

Procedure:

1- Set the direction for the widget to right to left. (Use dir="rtl")

Actual Result:

  • The closing end of the progress bar is missing

Expected Result:

  • When the direction of the widget is left to Right (LTR), the closing end of the progress bar has a bold border. This border is placed on the right end.
  • On setting the direction to be right to left (RTL), the closing end should also have this bold border. In this case it is placed on the left end.

Attachments (7)

progressBar_defect.jpg (26.2 KB) - added by Alia Naguib 7 years ago.
This attached image shows the progress bar defect
claro_rtl.css.patch (322 bytes) - added by Douglas Hays 7 years ago.
patch from Hossam Katory (IBM, CCLA)
soria_rtl.css.patch (513 bytes) - added by Douglas Hays 7 years ago.
patch from Hossam Katory (IBM, CCLA)
tundra_rtl.css.patch (503 bytes) - added by Douglas Hays 7 years ago.
patch from Hossam Katory (IBM, CCLA)
nihilo_rtl.css.patch (520 bytes) - added by Douglas Hays 7 years ago.
patch from Hossam Katory (IBM, CCLA)
ProgressBar_rtl.patch (2.0 KB) - added by Alia Naguib 7 years ago.
progressBarCombined.patch (4.8 KB) - added by bill 7 years ago.
combined version of patch

Download all attachments as: .zip

Change History (14)

Changed 7 years ago by Alia Naguib

Attachment: progressBar_defect.jpg added

This attached image shows the progress bar defect

Changed 7 years ago by Douglas Hays

Attachment: claro_rtl.css.patch added

patch from Hossam Katory (IBM, CCLA)

Changed 7 years ago by Douglas Hays

Attachment: soria_rtl.css.patch added

patch from Hossam Katory (IBM, CCLA)

Changed 7 years ago by Douglas Hays

Attachment: tundra_rtl.css.patch added

patch from Hossam Katory (IBM, CCLA)

Changed 7 years ago by Douglas Hays

Attachment: nihilo_rtl.css.patch added

patch from Hossam Katory (IBM, CCLA)

comment:1 Changed 7 years ago by bill

Component: GeneralDijit
Milestone: tbd1.9
Owner: set to bill
Summary: Misplaced progress bar border when direction is RTLProgressBar: misplaced border when direction is RTL

comment:2 Changed 7 years ago by bill

Cc: Douglas Hays added
Owner: changed from bill to Alia Naguib
Status: newpending

Where are the ProgressBar_rtl.css files? The patches reference them but they don't exist.

Changed 7 years ago by Alia Naguib

Attachment: ProgressBar_rtl.patch added

comment:3 Changed 7 years ago by Alia Naguib

Status: pendingnew

Attachment (ProgressBar_rtl.patch) added by ticket reporter.

Changed 7 years ago by bill

Attachment: progressBarCombined.patch added

combined version of patch

comment:4 Changed 7 years ago by bill

Owner: changed from Alia Naguib to bill
Status: newassigned

OK thanks. I'll need to make a few modifications:

  • There's no need to list the color in the RTL files; it's better to just reset the border width. Then if users customize the theme they only have to change the color in one place.
  • I see there's no dijitProgressBarRtl class so you worked around that in the RTL file, but not perfectly, because a new ProgressBar({dir: "ltr"}) inside of an RTL page will incorrectly switch to RTL style.
Last edited 7 years ago by bill (previous) (diff)

comment:5 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29919]:

Fix border of ProgressBar bar in RTL, fixes #15942 !strict.

comment:6 Changed 6 years ago by Bill Keese <bill@…>

In 959a31c8cc50bcafb31c5c27153272666d1aea95/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 6 years ago by Bill Keese <bill@…>

In 4ee8ea286da51bf7279a52d2c31d0f76af23f4e3/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.