Can't cancel BusyButton in onClick handler

[Gavin R]

Attempts to cancel() a BusyButton? in a click handler for a dojox.form.BusyButton? do not work because this.makeBusy() seems to be called _After_ the click handler in the ​1.7.3 code (and ​1.8).

[Dspriggs]

I'm having the same issue. This would fix it I think:

change this current code:

_onClick: function(e){

summary: on button click the button state gets changed

only do something if button is not busy if(!this.isBusy){

this.inherited(arguments); calls onClick()

this.makeBusy();

}

}

to this:

_onClick: function(e){

summary: on button click the button state gets changed

only do something if button is not busy if(!this.isBusy){

this.makeBusy();

this.inherited(arguments); calls onClick()

}

}

[Nick Fenwick]

Moving the makeBusy() call to before this.inherited() does not work. makeBusy() sets the button to disabled, and then inside inherited() _ButtonMixin's onClick handler, that would invoke your onClick hander (that would then cancel() the busy button) exits early because it checks this.disabled.

I'll attach a suggested patch.

[Nick Fenwick]

Suggested patch to BusyButton?.js. I got bogged down on the tests page doing an AMD conversion, the BusyButton?.js file needs breaking into many smaller modules.

[Gavin R]

Any word on this getting into the next version of Dojo? I thought it would get into 1.8 but it's still broken in that version for us.

[Gavin R]

I've verified that this patch seems to fix my issue. What else needs to happen on this for it to be integrated?

[dylan]

@gavinr, if you can create a PR, I'll review and land it this week. Thanks!

[Gavin R]

Thanks dylan. PR below. Let me know if I need anything else (test cases, etc).

​https://github.com/dojo/dojox/pull/199

[dylans <[email protected]…>]

In 7c88fa3a6a7e75003ac876bd14350ef3270f0752/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?