Opened 7 years ago

Closed 7 years ago

#15937 closed enhancement (fixed)

dojo/text should use dojo/request

Reported by: Kitson Kelly Owned by: Kitson Kelly
Priority: undecided Milestone: 1.9
Component: Core Version: 1.8.0
Keywords: Cc: bforbes, Rawld Gill
Blocked By: Blocking:

Description

Current the loader plugin dojo/text uses dojo/_base/xhr or require.gettext for retrieving and caching text. It should instead use dojo/request which will provide a more cross-platform module.

Attachments (1)

dojo_text_request.patch (929 bytes) - added by Kitson Kelly 7 years ago.
Refactors dojo/text to use dojo/request instead of _base/xhr and require.gettext

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by Kitson Kelly

Milestone: tbd1.9
Owner: set to Kitson Kelly
Status: newassigned

comment:2 Changed 7 years ago by Kitson Kelly

Cc: bforbes Rawld Gill added

Changed 7 years ago by Kitson Kelly

Attachment: dojo_text_request.patch added

Refactors dojo/text to use dojo/request instead of _base/xhr and require.gettext

comment:3 Changed 7 years ago by Kitson Kelly

I have added an attachment to address this ticket. If I am right, this should then transparently support on Node or Browser based for the plugin without needing to rely specifically on the Dojo loader. I didn't feel comfortable checking this in until it had some proper review.

comment:4 Changed 7 years ago by bill

Everything should use dojo/request rather than dojo/_base/xhr, and will for 2.0, but IIRC it's impossible to change dojo/text before then because it wants do the request synchronously. Are you sure your patch works when djconfig is async:false?

comment:5 Changed 7 years ago by Kitson Kelly

Milestone: 1.92.0

comment:6 Changed 7 years ago by bill

Milestone: 2.01.9
Resolution: fixed
Status: assignedclosed

Oh actually I already fixed this in [30524], [30537], [30555].

Note: See TracTickets for help on using tickets.