[regression] 404 error in dojox/editor/plugins

[Douglas Hays]

Starting with [14805], there's a 404 error thrown when using dojox/editor/plugins with a theme other than tundra. This rule was changed from:
.tundra .dijitButtonNode .dijitArrowButtonInner{
to
.dijitButtonNode .dijitArrowButtonInner{
but this was left in:
background:url(../../../../dijit/themes/tundra/images/spriteArrows.png) no-repeat left top;
I don't know if this rule should be removed, or if the background property should be removed or if additional rules for each theme should be added.

[Douglas Hays]

error occurs in dojox/editor/plugins/resources/editorPlugins.css

[bill]

I don't understand why it gets a 404.

[bobz79]

Any update on this? The 404 error comes since tundra theme is not there in standard package since dojo 1.7.

[Douglas Hays]

possible fix

[Douglas Hays]

bill, can you review the attached patch? I didn't see any reason for the wayward rule in editorPlugins.css. dijit.css was being imported AFTER claro.css in a couple of test HTML files causing the .dijitButtonNode .dijitArrowButtonInner selector in dijit.css to have a higher priority than the theme specific rule for .claro .dijitArrowButtonInner.

[Douglas Hays]

I'm testing via dojox/editor/tests/editorTablePlugs.html?theme=claro using the dropdown arrow in the editor toolbar.

[bill]

@doughays - At a glance that patch looks good to me. I don't see why that CSS code was there in the first place either.

[Douglas Hays]

In [30126]:

Fixes #15931. Remove duplicate dijit.css test file imports and wayward tundra CSS rule.