Changes between Initial Version and Version 1 of Ticket #15909, comment 2


Ignore:
Timestamp:
Aug 31, 2012, 9:06:07 AM (9 years ago)
Author:
Adrian Vasiliu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15909, comment 2

    initial v1  
    11The same trouble also holds for the button with "Back" label in the "Shape" tab of the "Buttons" demo of the gallery. And it hurts on both Firefox and IE (including IE9).
    22
    3 The good news is... that this does not reveal a defect in the library. It is defect in the demo with "compat" desktop browsers. It has nothing to do with the behavior of the typical "Back" buttons as they can be seen in most mobile apps. Indeed, in the mobile gallery, these two occurrences of "Back" buttons are usages of dojox/mobile/Button with custom CSS provided in the demo.
     3The good news is... that this does not reveal a defect in the library. It is a defect in the demo with "compat" desktop browsers. It has nothing to do with the behavior of the typical "Back" buttons as they can be seen in most mobile apps. Indeed, in the mobile gallery, these two occurrences of "Back" buttons are usages of dojox/mobile/Button with custom CSS provided in the demo.
    44
    5 Nowadays, users get the "Back" buttons in two very easy ways, without writing any custom CSS: either by setting the "back" property of dojox/mobile/Heading, or using a dojox/mobile/!ToolBarButton and setting its "arrow=left|right" property (the later only exists since Dojo 1.8). These work fine including in "compat" mode.
     5Nowadays, users get the "Back" buttons in two very easy ways, without writing any custom CSS: either by setting the "arrow=left|right" property of a !ToolBarButton (the property only exists since Dojo 1.8), or by setting the "back" property of a Heading (which internally creates a !ToolBarButton). These work fine including in "compat" mode.
    66
    77From this point of view, we could imagine to modify the gallery demo to use for the "back" buttons a !ToolBarButton instead of a customized Button. However, the demo also shows buttons with a rounded shape (in the "Buttons" view) and with various custom colors and textures, so for consistency it might be better to just fix the CSS in the demo. On the other side, if we keep using in the gallery a Button with custom CSS for the "back" button, it might be misleading for users that would use the gallery for learning how to code, because they may miss the fact that there's a much easier solution to get back buttons... Maybe we should show both solutions in the gallery? or this would be overkill?...