AMD optimizer cannot do static analysis on dojox/mobile/deviceTheme

[Adam Peller]

see ​https://github.com/maqetta/maqetta/issues/2708

The ​Zazl Optimizer cannot perform static analysis on deviceTheme because of its unusual define signature. @rbackhouse suggests a workaround that Zazl seems to accept, inserting the module id. Why is it necessary for this module to run without define being defined?

[ykami]

deviceTheme.js may look AMD syntax, but it is for backward compatibility reason. In 1.8, loading deviceTheme asynchronously is not recommended, because that is often problematic. Actually none of the dojox.mobile test cases load it in the async manner. Instead, they load it with a script tag. So, my recommendation is to leave it out of the optimization layer.

[Adam Peller]

In Maqetta, we've actually been using async loading with mobile with some success. The Zazl optimizer works differently from static build layers. It computes the dependencies and builds the layers on demand. Apparently, it is not possible to leave the one module out of the optimization process. We will test the workaround we have, but it might be interesting to see if we can support async with dojox/mobile going forward and drop the back-compat syntax.

[Adam Peller]

bump. Looking for a workaround to this interim solution in 1.8 which will satisfy the zazl optimizer.

[Adam Peller]

Zazl ​worked around this problem.