Opened 7 years ago

Closed 7 years ago

#15890 closed defect (fixed)

[regression] Using JSONP (with ItemFileReadStore and xhrScriptPlugin) fills console with errors

Reported by: tonyerwin Owned by: Bryan Forbes
Priority: blocker Milestone: 1.8.1
Component: IO Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

I'm a member of the Maqetta team. In the attached sample, when I call fetch on my data store the data is successfully retrieved. However, the dev console in the browser gets filled with the same exception over and over and over again:

Uncaught TypeError?: Object frame0.8407082187477499 has no method 'getElementById' dojo.js:15 dom.byId dojo.js:15 _16 lib/dojo/dojo/request/script.js:24 _12 lib/dojo/dojo/request/script.js:48 _578.forEach dojo.js:15 _1e lib/dojo/dojo/request/script.js:47 _516

This used to work in Dojo 1.7.

Reproducible in both Chrome & FireFox? (Mac).

Attachments (2)

jsonpProblemTestCase.html (1.4 KB) - added by tonyerwin 7 years ago.
test case
jsonpSimplified.html (1.0 KB) - added by bill 7 years ago.
simplified test case

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by tonyerwin

Attachment: jsonpProblemTestCase.html added

test case

comment:1 Changed 7 years ago by Kris Zyp

Owner: changed from Kris Zyp to Bryan Forbes
Status: newassigned

comment:2 Changed 7 years ago by bill

Component: DataIO
Milestone: tbd1.8.1
Summary: Using JSONP (with ItemFileReadStore and xhrScriptPlugin) fills console with errors[regression] Using JSONP (with ItemFileReadStore and xhrScriptPlugin) fills console with errors

Started in [28744].

Changed 7 years ago by bill

Attachment: jsonpSimplified.html added

simplified test case

comment:3 Changed 7 years ago by dylan

Priority: undecidedblocker

comment:4 Changed 7 years ago by Bryan Forbes

In [29706]:

Check ioArgs when adding dead scripts. refs #15890 !strict

comment:5 Changed 7 years ago by Bryan Forbes

In [29707]:

Check ioArgs when adding dead scripts (1.8 backport). refs #15890 !strict

comment:6 Changed 7 years ago by Bryan Forbes

Resolution: fixed
Status: assignedclosed

The code in _addDeadScripts wasn't checking the old ioArgs, so the dynamic change to it wasn't getting picked up. I have fixed it and backported the fix to the 1.8 branch.

Note: See TracTickets for help on using tickets.