Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15888 closed defect (fixed)

on(window, ...) fails if there's a DOMNode with id=on (IE)

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.8.1
Component: Events Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

When setting up advice on window, as dijit does via:

on(window, "unload", ...)

It gets an error when there's a DOMNode with id="on". This code in on.js should be more robust:

if(target.on && typeof type != "function"){ 

(or we should say that we don't allow DOMNodes with id="on").

Exposed by a new test for the parser.

Change History (3)

comment:1 Changed 7 years ago by bill

Milestone: tbd1.8.1
Owner: changed from Kris Zyp to bill
Status: newassigned

comment:2 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29539]:

If there's an DOMNode with id="on", don't get confused into thinking that window.on() is a function you can call. Fixes #15888, refs #15871 on trunk !strict.

comment:9 Changed 7 years ago by bill

In [29540]:

If there's an DOMNode with id="on", don't get confused into thinking that window.on() is a function you can call. Fixes #15888, refs #15871 on 1.8 branch !strict.

Note: See TracTickets for help on using tickets.