Opened 10 years ago

Closed 5 years ago

Last modified 5 years ago

#15879 closed defect (fixed)

AutoRotator / Rotator cannot be destroyed

Reported by: Aaasaasa Owned by: dante
Priority: undecided Milestone: 1.13
Component: DojoX Widgets Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

Hello,

I've found a bug in the dojox.widget.Rotator on destroy()

I have added: if(wfe!=null){ wfe.remove(); }else{ return true; } and it works. It's not a solution but i haven't time to find a cause. Programmatically it not works, just declaratively

Change History (5)

comment:1 Changed 7 years ago by dylan

Milestone: tbd → 1.12
Resolution: → patchwelcome
Status: new → closed
Summary: AutoRotator / Rotator cann't be destreyed → AutoRotator / Rotator cannot be destroyed

Realistically, this is not going to get fixed unless someone submits a pull request. Closing as patchwelcome.

comment:2 Changed 5 years ago by dylan

Resolution: patchwelcome
Status: closed → reopened

comment:3 Changed 5 years ago by dylan

PR at ​https://github.com/dojo/dojox/pull/261 solves this issue and more.

comment:4 Changed 5 years ago by dylans <[email protected]…>

Resolution: → fixed
Status: reopened → closed

In cc13d35/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:5 Changed 5 years ago by dylans <[email protected]…>

In fbd19a79/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?
Note: See TracTickets for help on using tickets.