Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1587 closed defect (fixed)

Editor2 should create a dojoUri from an overridden toolbarTemplatePath

Reported by: guest Owned by: liucougar
Priority: high Milestone:
Component: Editor Version: 0.3
Keywords: Cc: bill@…
Blocked By: Blocking:

Description

In the widget src, the default toolbarTemplatePath is created with a dojoUri, but any overridden value in the dom element is just passed to the toolbar widget as a string. Attached is a patch that will always create a uri from the value of toolbarTemplatePath.

Attachments (1)

1587.patch (977 bytes) - added by guest 13 years ago.

Download all attachments as: .zip

Change History (9)

Changed 13 years ago by guest

Attachment: 1587.patch added

comment:1 Changed 13 years ago by bill

Milestone: 0.40.5
Owner: changed from bill to liucougar

comment:2 Changed 13 years ago by dylan

Component: WidgetsEditor

comment:3 Changed 13 years ago by liucougar

as of dojo 0.4, dojo.uri.Uri is the only recognized object for templatePath/templateCssPath, I don't think I can merge this patch

or Bill do you have other thoughts?

comment:4 Changed 13 years ago by liucougar

Cc: bill@… added

comment:5 Changed 13 years ago by bill

Hmm, seems like, in the same way that an attribute setting like disabled="true" is converted to a Boolean value, templatePath/templateCssPath etc. should be converted to a dojo.uri.Uri object. (This has nothing to do w/the editor per se; just a comment in general about our automatic argument conversion.)

comment:6 Changed 13 years ago by liucougar

Milestone: 0.50.4.1
Status: newassigned

comment:7 Changed 13 years ago by liucougar

Resolution: fixed
Status: assignedclosed

(In [6480]) fixes #1587: now all *Path can be set as a string in markup, which should be relative to root of dojo if it is a relative path

comment:8 Changed 12 years ago by (none)

Milestone: 0.4.1

Milestone 0.4.1 deleted

Note: See TracTickets for help on using tickets.