#1587 closed defect (fixed)
Editor2 should create a dojoUri from an overridden toolbarTemplatePath
Reported by: | guest | Owned by: | liucougar |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | Editor | Version: | 0.3 |
Keywords: | Cc: | [email protected]… | |
Blocked By: | Blocking: |
Description
In the widget src, the default toolbarTemplatePath is created with a dojoUri, but any overridden value in the dom element is just passed to the toolbar widget as a string. Attached is a patch that will always create a uri from the value of toolbarTemplatePath.
Attachments (1)
Change History (9)
Changed 14 years ago by
Attachment: | 1587.patch added |
---|
comment:1 Changed 14 years ago by
Milestone: | 0.4 → 0.5 |
---|---|
Owner: | changed from bill to liucougar |
comment:2 Changed 14 years ago by
Component: | Widgets → Editor |
---|
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
Cc: | [email protected]… added |
---|
comment:5 Changed 14 years ago by
Hmm, seems like, in the same way that an attribute setting like disabled="true" is converted to a Boolean value, templatePath/templateCssPath etc. should be converted to a dojo.uri.Uri object. (This has nothing to do w/the editor per se; just a comment in general about our automatic argument conversion.)
comment:6 Changed 14 years ago by
Milestone: | 0.5 → 0.4.1 |
---|---|
Status: | new → assigned |
comment:7 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
as of dojo 0.4, dojo.uri.Uri is the only recognized object for templatePath/templateCssPath, I don't think I can merge this patch
or Bill do you have other thoughts?