Opened 8 years ago

Last modified 8 years ago

#15864 closed defect

ExpandingTextAreaMixin: resize should be from startup(), not postCreate() — at Version 1

Reported by: bill Owned by: Douglas Hays
Priority: undecided Milestone: 1.8.1
Component: Dijit - Form Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

ExpandingTextAreaMixin.js does resizing from postCreate(), but the widget may not be attached to the DOM at that point. It should be from startup().

Admittedly often the widget is attached to the DOM in postCreate(), and it's almost always attached to the DOM after a setTimeout(..., 0), but this is not guaranteed.

Also, having a _resizeLater() method (rather than just calling resize()) may be unnecessary after moving the resize calls to startup().

Attaching patch to move the resize() calls, plus to use on() rather than this.connect(), since the latter will probably go away for 2.0.

Change History (2)

Changed 8 years ago by bill

Attachment: eta.patch added

comment:1 Changed 8 years ago by bill

Description: modified (diff)
Note: See TracTickets for help on using tickets.