Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15851 closed defect (fixed)

Destroyable: a handle can't be owned by multiple Destroyables

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.8.1
Component: Dijit Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Destroyable probably shouldn't set handle._odh (storing it's own handle inside the original handle) because it creates an unnecessary limitation that a given handle can only be owned by one Destroyable object. Rather, _odb can be a variable in the closure.

Change History (6)

comment:1 Changed 7 years ago by bill

Milestone: tbd → 2.0

comment:2 Changed 7 years ago by bill

Description: modified (diff)

comment:3 Changed 7 years ago by bill

Description: modified (diff)
Summary: _Widget.destroy(): release all handles returned from _Widget.on() → Destroyable: a handle can't be owned by multiple Destroyables
Type: enhancement → defect

Turns out _WidgetBase already releases handles (for DOMNode connections anyway), so reappropriating this ticket for the Destroyable issue.

comment:4 Changed 7 years ago by bill

Milestone: 2.0 → 1.8.1

comment:5 Changed 7 years ago by bill

Resolution: → fixed
Status: new → closed

In [29491]:

Cleanup Destroyable code, allowing a given handle to owned by multiple Destroyable instances, and fixing double-call to handle._odh.remove(), fixes #15851 on trunk/ !strict.

comment:6 Changed 7 years ago by bill

In [29492]:

Cleanup Destroyable code, allowing a given handle to owned by multiple Destroyable instances, and fixing double-call to handle._odh.remove(), fixes #15851 on 1.8/ branch !strict.

Note: See TracTickets for help on using tickets.