Opened 7 years ago

Closed 6 years ago

#15835 closed task (fixed)

standardize camel case vs. dashed properties

Reported by: bill Owned by: bill
Priority: high Milestone: 2.0
Component: Dijit Version: 1.8.0
Keywords: Cc: Kitson Kelly
Blocked By: Blocking:

Description

Should _WidgetBase.set()/get() take camel cased or dash separated attributes? Should the widget properties themselves be camel case or dash separated?

Generally, widgets have camel cased attributes, like maxRatio. But Dialog.js has "aria-describedby", with a dash. Also, any aria attribute can be specified to set() as a dashed attribute name.

See also http://msdn.microsoft.com/en-us/library/ie/cc848879(v=vs.85).aspx differentiating between attribute name and property name, which suggests that set() should use the dashed name but the property should be camel case. However, this contradicts our design for Stateful, to not do any conversion.

Change History (3)

comment:1 Changed 7 years ago by bill

Cc: Kitson Kelly added
Milestone: tbd2.0

comment:2 Changed 6 years ago by bill

Priority: undecidedhigh

comment:3 Changed 6 years ago by bill

Resolution: fixed
Status: newclosed

I don't think this will be an issue anymore in 2.0 as we'll get rid of set() and get() entirely.

Note: See TracTickets for help on using tickets.