Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#15831 closed defect (fixed)

dojo/touch: iOS4 support for touch.move

Reported by: bill Owned by: Eric Durocher
Priority: undecided Milestone: 1.7.7
Component: Events Version: 1.8.0
Keywords: Cc: Adrian Vasiliu
Blocked By: Blocking:

Description (last modified by bill)

See #15817, #15821. As per http://www.icab.de/blog/2011/10/17/elementfrompoint-under-ios-5/ need to have special code for iOS4 for it's broken elementFromPoint() method.

Attachments (1)

15831.patch (1.1 KB) - added by Eric Durocher 7 years ago.
Pass page coordinates to broken iOS 4' s elementFromPoint - Eric Durocher (IBM, CCLA)

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by bill

Cc: Adrian Vasiliu added
Description: modified (diff)
Milestone: tbd1.8.1
Owner: changed from Kris Zyp to Eric Durocher
Status: newassigned
Summary: dojo/touch: iOS4 support for touchmovedojo/touch: iOS4 support for touch.move

Since I don't have iOS4 I think that one of you said you would supply a patch to get it working.

Changed 7 years ago by Eric Durocher

Attachment: 15831.patch added

Pass page coordinates to broken iOS 4' s elementFromPoint - Eric Durocher (IBM, CCLA)

comment:2 Changed 7 years ago by Eric Durocher

The iOS 4 sniff code is copied from dojox/mobile/sniff for now, longer term (if/when #15827 is done) this should be removed. Also I copied the sniff code as is for clarity but feel free to make it a one-liner if you prefer...

comment:3 Changed 7 years ago by Adrian Vasiliu

Tested this patch on iPhone iOS 4.3.3:

  • touch_bug.html from #15821: OK
  • dojo/tests/dnd/test_dnd.html: KO (the drag triggers a browser scroll and it's impossible to drop), however it didn't work before the changes in dojo/touch.js for #15821 either, so this seems an unrelated trouble with dojo/dnd on iOS 4.

(and both tests are of course still OK on iOS 5).

comment:4 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29473]:

fix touch.move on iOS4, thanks edurocher, fixes #15831 on 1.8/ branch !strict

comment:5 Changed 7 years ago by bill

In [29474]:

fix touch.move on iOS4, thanks edurocher, fixes #15831 on trunk !strict

comment:6 Changed 5 years ago by bill

Milestone: 1.8.11.7.7

Backported to 1.7 in e7403082d02faba2e47cb645d2532dd2920f60b8.

Note: See TracTickets for help on using tickets.