Opened 7 years ago

Closed 7 years ago

#15811 closed defect (fixed)

[regression] Standby widget throwing exceptions in IE

Reported by: Douglas Hays Owned by: haysmark
Priority: undecided Milestone: 1.7.4
Component: DojoX Widgets Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description

Starting with [26714] in 1.7.0, the Standby widget is incorrectly setting "overflow" instead of just getting it.

this._oldOverflow = domStyle.set(body, "overflow");
...
this._oldBodyParentOverflow = domStyle.set(body.parentNode, "overflow");

Attachments (1)

15811.patch (824 bytes) - added by haysmark 7 years ago.
Fix regression in AMD refactor that called domStyle.set instead of get. Fixes #15811.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by Douglas Hays

Owner: changed from dante to Adam Peller
Status: newassigned

comment:2 Changed 7 years ago by Adam Peller

Milestone: tbd1.8.1

Changed 7 years ago by haysmark

Attachment: 15811.patch added

Fix regression in AMD refactor that called domStyle.set instead of get. Fixes #15811.

comment:3 Changed 7 years ago by haysmark

Adam I attached a fix for this ticket. It was fairly straightforward to change set->get, if it makes no difference to you I will commit it.

comment:4 Changed 7 years ago by Adam Peller

+1

comment:5 Changed 7 years ago by haysmark

Resolution: fixed
Status: assignedclosed

In [29477]:

Fix regression in AMD refactor that called domStyle.set instead of get. Fixes #15811.

comment:6 Changed 7 years ago by Adam Peller

don't know if we're going to have a branch for 1.8 or not

comment:7 Changed 7 years ago by haysmark

Bill created one Friday, I was going to backport it to 1.8 and 1.7 if that's ok.

comment:8 Changed 7 years ago by haysmark

err csnover created it, Bill is already busy backporting :)

comment:9 Changed 7 years ago by Adam Peller

Milestone: 1.8.11.7.4
Resolution: fixed
Status: closedreopened

comment:10 Changed 7 years ago by Adam Peller

Owner: changed from Adam Peller to haysmark
Status: reopenedassigned

comment:11 Changed 7 years ago by haysmark

In [29478]:

Backport [29477]. Refs #15811.

comment:12 Changed 7 years ago by haysmark

Resolution: fixed
Status: assignedclosed

In [29479]:

Backport [29477]. Fixes #15811.

Note: See TracTickets for help on using tickets.