[regression] TitlePane: cannot toggle via ENTER key (IE9)

[bill]

TitlePane will toggle via click or SPACE key, but not ENTER key. Works in 1.7 but fails on trunk.

[bill]

Another problem caused by the issue with dojo.connect()'s synthetic keypress event on IE9, see #15709. I will workaround it in the same way as I did there.

[bill]

In [29420]:

fix ENTER key toggle on IE9, fixes #15793 !strict.

[bill]

On further inspection, I think that when TitlePane was using the synthetic onkeypress event, it was failing because of the <button> nodes in the test file. Seems that since those nodes don't have a type specified, they default to type=submit, which somehow blocks the native keypress event from occurring. It just happened to work before #14954 was fixed because there was still the faux event created by the dojo.connect() code's synthetic keypress event.

The change to use keydown rather than keypress is an improvement anyway since it would have been needed for the 2.0 transition, where we drop dojo.connect(), but it wasn't necessary to fix the problem, since it was more of a problem with the test case.

[bill]

In [30342]:

fix type of buttons in test_TitlePane.html test file, refs #15793

[bill]

In [30343]:

fix type of buttons in test_TitlePane.html test file (1.8 branch), refs #15793

[haysmark]

This was working in 1.6 and 1.7 branches so doesn't need to be backported.

[bill]

Agreed, although on the 1.7 branch it's working in a fragile way. See #14954. The reason it's working is because of the event.stop() call in TitlePane._onTitleKey(). It's also working because of the <button> nodes in the test file, see #16570.

[Bill Keese <[email protected]…>]

In 661d58249f4be8a0c33233511243de05edd392d2/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?