Opened 8 years ago

Closed 8 years ago

#15788 closed defect (fixed)

no error message for illegal optimize value

Reported by: bill Owned by: Rawld Gill
Priority: low Milestone: 1.9
Component: BuildSystem Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

I did:

./build.sh action=release profile=standard optimize=comments.keepLines releaseDir=/workspace/release-comments copyTests=true

Rather than aborting, giving an error message that "comments.keepLines is not a valid option for optimize", it ran, using I'm not sure what optimization.

optimize=foo presents an error message (although it would be better if it aborted the build), but anything that starts with "comment", for example optimize=commentsXXX, doesn't seem to report any error.

Change History (6)

comment:1 Changed 8 years ago by bill

Description: modified (diff)

comment:2 Changed 8 years ago by bill

Strangely, using comment.keeplines, which is valid according to ​http://livedocs.dojotoolkit.org/build/qref:

./build.sh action=release profile=standard optimize=comment.keeplines releaseDir=/workspace/release-comments copyTests=true

... gives an error message that:

error(319) Unknown optimize value. value: comment.keeplines

comment:3 Changed 8 years ago by Rawld Gill

Milestone: tbd → 1.9

comment:4 Changed 8 years ago by Rawld Gill

Status: new → assigned

comment:5 Changed 8 years ago by Rawld Gill

Priority: undecided → low

comment:6 Changed 8 years ago by Rawld Gill

Resolution: → fixed
Status: assigned → closed

In [31228]:

fixed regular expr that failed to detect improper optimize values; fixed bug that failed to abort build if errors detected in profile; fixes #15788; !strict

Note: See TracTickets for help on using tickets.