Changes between Initial Version and Version 1 of Ticket #15786, comment 9


Ignore:
Timestamp:
Aug 29, 2012, 7:07:57 PM (9 years ago)
Author:
Adrian Vasiliu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15786, comment 9

    initial v1  
    1 I just wonder whether it is a typical pattern for _onClick handlers to call e.preventDefault(). In any case, in dojox.mobile, this this *not* done by ListItem._onClick, nor ToolBarButton._onClick. Shouldn't all treat the events consistently?
     1I just wonder whether it is a typical pattern for _onClick handlers to call e.preventDefault(). In any case, in dojox.mobile, this this *not* done by !ListItem._onClick, nor !ToolBarButton._onClick. Shouldn't all treat the events consistently?
    22
    3 On the other side, in dijit, dijit.form._ButtonMixin._onClick does call e.preventDefault() but only in some cases: if there's no user-defined action, plus other conditions depending on the type of the button. And its subclass dijit.form.Button conditionally calls both e.preventDefault() and e.stopPropagation(). Note that our TabBarButton can also get user-defined actions.
     3On the other side, in dijit, dijit.form._ButtonMixin._onClick does call e.preventDefault() but only in some cases: if there's no user-defined action, plus other conditions depending on the type of the button. And its subclass dijit.form.Button conditionally calls both e.preventDefault() and e.stopPropagation(). Note that our !TabBarButton can also get user-defined actions.
    44
    55I can of course perform non-regression tests (tomorrow) for this proposed change in TabBarButton, knowing that there are many situations to test (on many devices).