Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15777 closed defect (fixed)

Tooltip: empty (and invalid) dir setting

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.7.4
Component: Dijit Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

In Dojo 1.8 and 1.7 the Tooltip has an empty dir attribute. The "dir" attribute cannot have an empty value. It seems to be coming from dijit.Tooltip:

<div id="dijit__MasterTooltip_0" class="dijitTooltip dijitTooltipBelow dijitTooltipABLeft" 
widgetid="dijit__MasterTooltip_0" style="">
<div class="dijitTooltipContainer dijitTooltipContents" align="left" role="alert"
data-dojo-attach-point="containerNode" dir=""></div>

The "dir" attribute is not being given to the Tooltip widget, but the MasterTooltip seems to have it nonetheless in the "containerNode"

Change History (6)

comment:1 Changed 7 years ago by bill

Milestone: tbd1.8
Status: newassigned

comment:2 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29406]:

Don't call set("textDir", val) if val is undefined, null, "", etc. It should only be "ltr" or "rtl". Fixes problem with empty dir setting on Tooltip.containerNode. Fixes #15777 !strict.

comment:3 Changed 7 years ago by Douglas Hays

bill, is it OK if I make the same change to 1.7.4?

comment:4 Changed 7 years ago by bill

Sure, I think it will work there too.

comment:5 Changed 7 years ago by Douglas Hays

In [29649]:

Refs #15777. Backport [29406] to the 1.7 branch. Fixed whitespace issues in 1.8 and trunk.

comment:6 Changed 7 years ago by Douglas Hays

Milestone: 1.81.7.4
Note: See TracTickets for help on using tickets.