Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15774 closed defect (fixed)

Unit test, text.html, looks for wrong line-ending

Reported by: jonathansampson Owned by: Rawld Gill
Priority: undecided Milestone: 1.9
Component: Loader Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

The test located in tests\_base\loader\requirejs\text\text.html fails due to the assumption that only the \r line-ending is present in the variable actual.

t.is(expected, actual.replace(/\n/g, ""));

Including other line-endings for safety resolves this failure:

t.is(expected, actual.replace(/(\r\n|\r|\n)/g, ""));

Attachments (1)

text.html (1.9 KB) - added by jonathansampson 7 years ago.
Corrected text file.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by jonathansampson

Attachment: text.html added

Corrected text file.

comment:1 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [30810]:

repair improper test assert; thanks jonathansampson; fixes #15774

comment:2 Changed 7 years ago by Rawld Gill

In [30811]:

repair improper test assert; thanks jonathansampson; fixes #15775; refs #15774, #15771

comment:3 Changed 7 years ago by Rawld Gill

Milestone: tbd1.9
Note: See TracTickets for help on using tickets.