Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#15773 closed task (fixed)

tests/_base/html_quirks.html failure on IE10

Reported by: jonathansampson Owned by: bill
Priority: undecided Milestone: 1.6.2
Component: HTML Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

HTML Quirks test assumes all IE versions behave the same when in quirks mode, and therefore issued custom tests for IE. This is no longer the case with IE10+, as IE will not behave like other popular browsers.

dojo.marginBox('sq100margin10pad10').w;

The above test results in 140 in both Chrome and IE10+. In IE lte 9 it results in 120.

The following change, in tests\_base\html_quirks.html, to the IE condition resolves this issue:

if (has("ie") <= 9)

This results in 0 failures under IE10+.

Attachments (1)

html_quirks.html (9.1 KB) - added by jonathansampson 7 years ago.
Updated html_quirks.html

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by jonathansampson

Attachment: html_quirks.html added

Updated html_quirks.html

comment:1 Changed 7 years ago by jonathansampson

Correction, I meant to say "IE will now behave like other popular browsers" instead of the negative.

comment:2 Changed 7 years ago by bill

Component: LoaderHTML
Milestone: tbd1.8
Owner: changed from Rawld Gill to bill
Status: newassigned
Summary: IE10 quirks unlike prior IE versionstests/_base/html_quirks.html failure on IE10

OK thanks, I'll check in.

comment:3 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29405]:

fix test failure on IE10, fixes #15773

comment:4 Changed 6 years ago by bill

In [30193]:

Rollback [30005] and [30009], which were wrong, and re-broke the html_quirks.html test on IE10. Refs #15773, #12342.

comment:27 Changed 6 years ago by bill

In [30194]:

backport [29405] test failure fix to 1.8 branch, refs #15773

comment:28 Changed 6 years ago by bill

In [30195]:

backport [29405] test failure fix to 1.7 branch, refs #15773

comment:29 Changed 6 years ago by bill

In [30196]:

backport [29405] test failure fix to 1.6 branch, refs #15773

comment:30 Changed 6 years ago by bill

Milestone: 1.81.6.2
Type: defecttask
Note: See TracTickets for help on using tickets.