Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15771 closed defect (fixed)

Unit test, relative.html, looks for wrong line-ending

Reported by: jonathansampson Owned by: Rawld Gill
Priority: undecided Milestone: 1.9
Component: Loader Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description

Current unit test contains the following:

t.is("hello world", one.message.replace(/\n/g, ""));

This assumes one.message consists only of \n characters as line-endings. This is not the case, and as such this test fails.

Expanding the pattern to include all line-endings resolves the issue.

t.is("hello world", one.message.replace(/(\r\n|\r|\n)/g, ""));

Attachments (1)

relative-tests.js (608 bytes) - added by jonathansampson 7 years ago.
Corrected text file.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by bill

Component: GeneralLoader
Owner: set to Rawld Gill

Changed 7 years ago by jonathansampson

Attachment: relative-tests.js added

Corrected text file.

comment:2 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [30809]:

repair improper test assert; thanks jonathansampson; fixes #15771

comment:3 Changed 7 years ago by bill

Milestone: tbd1.9

comment:4 Changed 7 years ago by Rawld Gill

In [30811]:

repair improper test assert; thanks jonathansampson; fixes #15775; refs #15774, #15771

Note: See TracTickets for help on using tickets.