Opened 7 years ago
Closed 7 years ago
#15770 closed defect (fixed)
[patch] [cla] dojox/html/_base (snarfStyles) picks up commented out styles, link tags, and @imports.
| Reported by: | Jared Jurkiewicz | Owned by: | Jared Jurkiewicz |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.8.1 |
| Component: | HTML | Version: | 1.7.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
dojox/html/_base (snarfStyles) picks up commented out styles, link tags, and @imports.
This is similar to bug: http://bugs.dojotoolkit.org/ticket/12133
If it processes a commented out block of links, etc, it will load them. And worse, if the comment block then ends up empty, the browser can actually lock up. This is seen with Google Chrome especially, but also can occur with IE 9. The snarfStyles function needs to escape those too, to skip them. Patch forthcoming.
Attachments (1)
Change History (4)
Changed 7 years ago by
| Attachment: | 15770.patch added |
|---|
comment:1 Changed 7 years ago by
| Component: | General → HTML |
|---|---|
| Owner: | set to Jared Jurkiewicz |
| Status: | new → assigned |
| Summary: | dojox/html/_base (snarfStyles) picks up commented out styles, link tags, and @imports. → [patch] [cla] dojox/html/_base (snarfStyles) picks up commented out styles, link tags, and @imports. |
comment:2 Changed 7 years ago by
| Milestone: | tbd → 1.8.1 |
|---|
Note: See
TracTickets for help on using
tickets.
Patch for this issue. (Includes test)