Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15764 closed defect (fixed)

Dialog: support for textDir property

Reported by: sashash Owned by: bill
Priority: undecided Milestone: 1.9
Component: Dijit Version: 1.7.3
Keywords: Cc:
Blocked By: Blocking:

Description


Attachments (3)

Dialog.patch (4.7 KB) - added by bill 7 years ago.
Patch from Alex Shensis (IBM, CCLA)
Dialog2.patch (4.7 KB) - added by bill 7 years ago.
update patch
Dialog3.patch (4.2 KB) - added by bill 7 years ago.
updated patch, fixed path to DOH but test still fails because enforceTextDirWithUcc() fails with a null argument

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Douglas Hays

Component: Dijit - FormDijit
Owner: changed from Douglas Hays to bill
Status: newassigned

comment:2 Changed 7 years ago by bill

Milestone: tbd2.0
Summary: Support for textDir property in dijit.DialogDialog: support for textDir property

Changed 7 years ago by bill

Attachment: Dialog.patch added

Patch from Alex Shensis (IBM, CCLA)

Changed 7 years ago by bill

Attachment: Dialog2.patch added

update patch

comment:3 Changed 7 years ago by bill

Milestone: 2.01.9

Changed 7 years ago by bill

Attachment: Dialog3.patch added

updated patch, fixed path to DOH but test still fails because enforceTextDirWithUcc() fails with a null argument

comment:4 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29556]:

Textdir support for Dialog, plus enhancement from #15734 to enforceTextDirWithUcc() to allow first argument to be null, fixes #15764, refs #15734, !strict. Patch from Alex Shensis (IBM, CCLA).

comment:5 Changed 7 years ago by bill

In [29598]:

Need to call this._set() so watch() notifications work, refs #15531, #15734, #15764 !strict.

Note: See TracTickets for help on using tickets.