Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15761 closed defect (fixed)

dojox.mobile.scrollable calculates incorrect height during resize() when inside a parent with borders

Reported by: nickmaynard Owned by: Patrick Ruzand
Priority: undecided Milestone: 1.9.1
Component: DojoX Mobile Version: 1.8.0rc1
Keywords: Cc:
Blocked By: Blocking:

Description

The existing resize() calculation logic does not allow for situations where the parent has borders. In this case, a "v" scrollable with height "inherit" will overlay the borders of the parent.

The following will fix this - replace: h = this.domNode.offsetParent.offsetHeight + "px"; with: h = dojo.contentBox(this.domNode.offsetParent).h + "px";

(Obviously, adjust for AMD loading).

Change History (7)

comment:1 Changed 7 years ago by nickmaynard

Or, indeed: h = this.domNode.offsetParent.clientHeight + "px";

comment:2 Changed 7 years ago by bill

Component: GeneralDojoX Mobile
Owner: set to Eric Durocher

comment:3 Changed 7 years ago by Sebastien Brunot

I've published a patch for http://trac.dojotoolkit.org/ticket/17050 that also solves this issue.

comment:4 Changed 7 years ago by Eric Durocher

Milestone: tbd1.9.1

comment:5 Changed 7 years ago by Patrick Ruzand

Owner: changed from Eric Durocher to Patrick Ruzand
Status: newassigned

comment:6 Changed 7 years ago by Patrick Ruzand <pruzand@…>

Resolution: fixed
Status: assignedclosed

In 426bb8150933d925816df9ca0195639802095b1a/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 7 years ago by Patrick Ruzand <pruzand@…>

In 26c19424e603eacedd7b8336d71e255841c036ef/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.