Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#15751 closed task (invalid)

dojox/date unreachable code

Reported by: bill Owned by: Adam Peller
Priority: low Milestone: 1.11
Component: Date Version: 1.8.0rc1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Should get rid of warning in hebrew.js

/workspace/trunk-release/dojo/dojox/date/hebrew.js:219: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
                                for (i;   i < e;  i++){
                                     ^

0 error(s), 1 warning(s)

Similarly for buddhist:

/workspace/trunk-release/dojo/dojox/date/buddhist.js:211: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
                                for (i;   i < e;  i++){
                                     ^

0 error(s), 1 warning(s)

And islamic:

/workspace/trunk-release/dojo/dojox/date/islamic.js:219: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
                                for (i;   i < e;  i++){
                                     ^

0 error(s), 1 warning(s)
Done (compile time:0.061s)

Change History (4)

comment:1 Changed 7 years ago by bill

Description: modified (diff)
Summary: dojox/date/hebrew build warningdojox/date/hebrew, dojox/date/buddhist unreachable code
Version: 1.7.31.8.0rc1

comment:2 Changed 7 years ago by bill

Description: modified (diff)
Summary: dojox/date/hebrew, dojox/date/buddhist unreachable codedojox/date unreachable code

comment:3 Changed 5 years ago by dylan

Milestone: tbd1.11
Priority: undecidedlow
Resolution: invalid
Status: newclosed

This isn't a valid warning, as the initial state of i is defined a few lines prior, instead of within the loop.

comment:4 Changed 5 years ago by bill

Actually, the warning is valid, that code is meaningless.

Note: See TracTickets for help on using tickets.